CIF-1400 - MyAccount - Account Information Page #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* CIF-1625 - Add CIF components as snapshot dependency * CIF-1625 - Ignore coverage of CIF components * CIF-1625 - Update README * CIF-1625 - Checkout branch of components project with same name * CIF-1625 - Checkout branch of components project with same name * CIF-1625 - Checkout branch of components project with same name
Create the Account Details page with the Account Details component
…IF Core Components (#54) * adjust Venia for CIF Core Components package changes * Add CIF components as snapshot dependency * Ignore coverage of CIF components * Update README * Checkout branch of components project with same name * update pom.xml use snapshot * remove commons-text dependency Co-authored-by: Mark J. Becker <herzog31@users.noreply.github.com>
…56) - replace no longer existing productlist clientlib with productcollection Co-authored-by: Mark J. Becker <herzog31@users.noreply.github.com>
* CIF-1084 - Add reset password page * CIF-1084 - Add reset password form component * CIF-1084 - Add ResetPassword component * CIF-1084 - Add feedback
dplaton
requested review from
mhaack,
herzog31,
LSantha,
laurentiumagureanu,
cjelger,
hbacila and
alkim91
10 tasks
Codecov Report
@@ Coverage Diff @@
## main #63 +/- ##
=========================================
Coverage 79.16% 79.16%
Complexity 13 13
=========================================
Files 1 1
Lines 24 24
Branches 4 4
=========================================
Hits 19 19
Misses 3 3
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
@dplaton why are there two PRs to |
|
@herzog31 I opened this one initially but I forgot to close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the "Account details" page which renders the "Account Details" React component (see adobe/aem-core-cif-components#409)
Related Issue
CIF-1400
Motivation and Context
How Has This Been Tested?
See tests in adobe/aem-core-cif-components#409
Screenshots (if appropriate):
Types of changes
Checklist: