Master65016 oct #1445
Merged
Master65016 oct #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Pavitra Khatri <pavitrakhatri@pavitras-mbp.corp.adobe.com>
* GH actions * Dummy change * dummy * change * Fix error * Fix error * fix error * Fix error * fix regex * Fix code * dummy change * Dummy change * Fix errors
…ordion, Wizard, Horizontal and Vertical Tabs (#1329) * Unable to select the secondary panels individually in Accordion, Tabs on Top, Vertical Tabs * revert bem class change of vertical tabs * FORMS-11475 add tests and fix * FORMS-11475 fix tests * FORMS-11475 fix test * Unable to select the secondary panels individually in Accordion, Tabs on Top, Vertical Tabs * revert bem class change of vertical tabs * FORMS-11475 add tests and fix * FORMS-11475 fix tests * FORMS-11475 fix test * FORMS-11475 fix test * Unable to select the secondary panels individually in Accordion, Tabs on Top, Vertical Tabs * revert bem class change of vertical tabs * FORMS-15150 update headers * FORMS-11475 add test * FORMS-11475 fix site test --------- Co-authored-by: demaurya <demaurya@adobe.com>
* Added new HTML types to field types * Adding hidden fieldtype * updated spec version
…date time picker widget (#1432) * FORMS-16264: Fixed test cases * FORMS-16264: Remove same instantiation of datetimepicker calendar element * FORMS-16264: Resolve conflict
Dev master8oct
Co-authored-by: Pavitra Khatri <pavitrakhatri@pavitras-mbp.corp.adobe.com>
…odel (#1409) * FORMS-16011 - Binding each core component's fieldType to its respective sling model. * fixing import * Fixing test collateral * fixing import order * Fixing star imports * Refactoring getFieldType to super class * Updating import * sorting import * Spec update to 0.14.1 | RTC approved * updating classpath with schema folder * fixing paths * updating schema with buttonType * incorporating review comments
Co-authored-by: Pavitra Khatri <pavitrakhatri@pavitras-mbp.corp.adobe.com>
This reverts commit 122f7d3.
* Updating type for buttons * Updating collateral for button * Fixing collateral and test * Fixing code and test * Fixing test and keeping button disabled * Adding code comments * Updating read me and test * Fixing reset test --------- Co-authored-by: Muskan Gupta <muskgupta@muskans-mbp.corp.adobe.com> Co-authored-by: Muskan Gupta <muskgupta@Muskans-MacBook-Pro.local> Co-authored-by: Rishi Mehta <rismehta@adobe.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/650 #1445 +/- ##
=================================================
+ Coverage 79.02% 79.11% +0.09%
- Complexity 777 798 +21
=================================================
Files 92 92
Lines 1840 1872 +32
Branches 272 276 +4
=================================================
+ Hits 1454 1481 +27
- Misses 249 252 +3
- Partials 137 139 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
verified that the test cases are passing on 6.5.21.0 but failing on 6.5.22.0 load 9 build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: