Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Undeploy for UI only apps #170

Merged
merged 14 commits into from
Mar 9, 2020
Merged

Conversation

sandeep-paliwal
Copy link
Contributor

AIO scripts will now throw error when undeploy actions is called but there is no backend.
Handle this gracefully in undeploy command and not call scripts undeploy unless we have a valid backend

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x ] I have signed the Adobe Open Source CLA.
  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ x] I have read the CONTRIBUTING document.
  • [x ] I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #170 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
+ Coverage   93.78%   93.81%   +0.03%     
==========================================
  Files          20       20              
  Lines         563      566       +3     
  Branches       67       68       +1     
==========================================
+ Hits          528      531       +3     
  Misses         31       31              
  Partials        4        4              
Impacted Files Coverage Δ
src/commands/app/undeploy.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 934783f...a776981. Read the comment docs.

@sandeep-paliwal sandeep-paliwal changed the title Handle Undeploy for UI only apss Handle Undeploy for UI only apps Mar 9, 2020
@@ -59,7 +60,11 @@ class Undeploy extends BaseCommand {

// undeploy
if (!flags.static) {
await scripts.undeployActions()
if (fs.existsSync('actions/')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandeep-paliwal can we change this to fs.existsSync('manifest.yml') so we are aligned with app-scripts and #171

@moritzraho moritzraho merged commit e8a657b into adobe:master Mar 9, 2020
@sandeep-paliwal sandeep-paliwal deleted the ui_only branch May 18, 2020 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants