-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Undeploy for UI only apps #170
Conversation
Sync with Master
Sync with master
Sync with Master
Sync with Master
Sync with Master
Sync with master
Sync with master
Sync with Master
Sync with Master
Codecov Report
@@ Coverage Diff @@
## master #170 +/- ##
==========================================
+ Coverage 93.78% 93.81% +0.03%
==========================================
Files 20 20
Lines 563 566 +3
Branches 67 68 +1
==========================================
+ Hits 528 531 +3
Misses 31 31
Partials 4 4
Continue to review full report at Codecov.
|
src/commands/app/undeploy.js
Outdated
@@ -59,7 +60,11 @@ class Undeploy extends BaseCommand { | |||
|
|||
// undeploy | |||
if (!flags.static) { | |||
await scripts.undeployActions() | |||
if (fs.existsSync('actions/')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sandeep-paliwal can we change this to fs.existsSync('manifest.yml') so we are aligned with app-scripts and #171
AIO scripts will now throw error when undeploy actions is called but there is no backend.
Handle this gracefully in undeploy command and not call scripts undeploy unless we have a valid backend
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: