Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-152697 Fix Marketo mobile horizontal scroll #2514

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

@Brandon32 Brandon32 added bug Something isn't working run-nala Run Nala Test Automation against PR @marketo Run Marketo Block Tests labels Jun 25, 2024
Copy link
Contributor

aem-code-sync bot commented Jun 25, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.77%. Comparing base (1a8acc6) to head (4a78b1e).
Report is 17 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2514      +/-   ##
==========================================
- Coverage   95.78%   95.77%   -0.02%     
==========================================
  Files         175      175              
  Lines       45913    45913              
==========================================
- Hits        43980    43972       -8     
- Misses       1933     1941       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

Copy link
Contributor

aem-code-sync bot commented Jun 26, 2024

Page Scores Audits Google
/drafts/bmarshal/mcz/marketo-scroll?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

github-actions bot commented Jul 5, 2024

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added the Stale label Jul 5, 2024
@github-actions github-actions bot removed the Stale label Jul 6, 2024
@Dli3 Dli3 added the verified PR has been E2E tested by a reviewer label Jul 8, 2024
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Jul 8, 2024

Skipped merging 2514: MWPW-152697 Fix Marketo mobile horizontal scroll due to failing checks

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Jul 10, 2024

Skipped 2514: MWPW-152697 Fix Marketo mobile horizontal scroll due to file overlap. Merging will be attempted in the next batch

@milo-pr-merge milo-pr-merge bot merged commit 8ef7d68 into stage Jul 15, 2024
31 checks passed
@milo-pr-merge milo-pr-merge bot deleted the bmarshal/marketo-horizontal-scroll branch July 15, 2024 09:15
@milo-pr-merge milo-pr-merge bot mentioned this pull request Jul 15, 2024
rohitsahu pushed a commit to rohitsahu/milo that referenced this pull request Jul 16, 2024
* stage:
  Mwpw-142267:  Merch What's Included and Merch Mnemonic List (TwP) (adobecom#2554)
  MWPW-149124 Improve Focus Page for Performance Improvement Tiger Team  (adobecom#2391)
  Correctly send the created PR slacks (adobecom#2566)
  MWPW-153167: caas-config change to enable hiding date detail information (adobecom#2553)
  MWPW-152016 - Localization target preview for transcreation (adobecom#2564)
  Relax CORS restrictions for module imports (adobecom#2549)
  MWPW-153600 [PEP] loader bar on PEP prompt is seen loaded Left to right in RTL locale (adobecom#2548)
  MWPW-146962 [milo] Text link behaving like button in FAQ section (adobecom#2530)
  MWPW-152280 MEP: Only preload fragments that are in the 1st section (adobecom#2525)
  MWPW-152697 Fix Marketo mobile horizontal scroll (adobecom#2514)
  MWPW-151513: Search results vanished when user clicks on Marquee CTA:Start free trail (adobecom#2406)
  MWPW-154013 PEP prompt redirection is broken in stage after the PEP dismissal PR merge (adobecom#2547)
  MWPW-153962: Introduce maslibs query parameter (adobecom#2544)
  Central georouting support (adobecom#2531)
  [MWPW-152278] Avoid empty CSS requests (adobecom#2524)
  MWPW-152918 Fix Marketo button font (adobecom#2513)

# Conflicts:
#	libs/deps/merch-card.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working @marketo Run Marketo Block Tests Ready for Stage run-nala Run Nala Test Automation against PR verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants