Correctly send the created PR slacks #2566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
narcis-radu
approved these changes
Jul 15, 2024
mokimo
force-pushed
the
stage-pr-created-to-slack-stage
branch
from
0a35699 to
4d12337
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2566 +/- ##
==========================================
- Coverage 95.87% 95.87% -0.01%
==========================================
Files 176 176
Lines 46133 46133
==========================================
- Hits 44229 44228 -1
- Misses 1904 1905 +1 ☔ View full report in Codecov by Sentry. |
robert-bogos
approved these changes
Jul 15, 2024
|
Reminder to set the |
This was referenced Jul 16, 2024
rohitsahu
pushed a commit
to rohitsahu/milo
that referenced
this pull request
Jul 16, 2024
* stage: Mwpw-142267: Merch What's Included and Merch Mnemonic List (TwP) (adobecom#2554) MWPW-149124 Improve Focus Page for Performance Improvement Tiger Team (adobecom#2391) Correctly send the created PR slacks (adobecom#2566) MWPW-153167: caas-config change to enable hiding date detail information (adobecom#2553) MWPW-152016 - Localization target preview for transcreation (adobecom#2564) Relax CORS restrictions for module imports (adobecom#2549) MWPW-153600 [PEP] loader bar on PEP prompt is seen loaded Left to right in RTL locale (adobecom#2548) MWPW-146962 [milo] Text link behaving like button in FAQ section (adobecom#2530) MWPW-152280 MEP: Only preload fragments that are in the 1st section (adobecom#2525) MWPW-152697 Fix Marketo mobile horizontal scroll (adobecom#2514) MWPW-151513: Search results vanished when user clicks on Marquee CTA:Start free trail (adobecom#2406) MWPW-154013 PEP prompt redirection is broken in stage after the PEP dismissal PR merge (adobecom#2547) MWPW-153962: Introduce maslibs query parameter (adobecom#2544) Central georouting support (adobecom#2531) [MWPW-152278] Avoid empty CSS requests (adobecom#2524) MWPW-152918 Fix Marketo button font (adobecom#2513) # Conflicts: # libs/deps/merch-card.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly pass on the milo-stage slack webhook url to the workflow
Related: #2474
Resolves: MWPW-152624
Test URLs: