MWPW-153167: caas-config change to enable hiding date detail information #2553
Conversation
|
sheridansunier
added
caas-configurator
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2553 +/- ##
=======================================
Coverage 95.81% 95.81%
=======================================
Files 175 175
Lines 45948 45988 +40
=======================================
+ Hits 44026 44065 +39
- Misses 1922 1923 +1 ☔ View full report in Codecov by Sentry. |
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
| @@ -363,6 +363,7 @@ const UiPanel = () => html` | |||
| <${Input} label="Use Light Text" prop="useLightText" type="checkbox" /> | |||
| <${Input} label="Use Overlay Links" prop="useOverlayLinks" type="checkbox" /> | |||
| <${Input} label="Show total card count at top" prop="showTotalResults" type="checkbox" /> | |||
| <${Input} label="Hide date for on-demand content" prop="hideDateInterval" type="checkbox" /> | |||
There was a problem hiding this comment.
L3 seems to fail the linter /* global ClipboardItem */ - might have been a linting update since this file had been last touched
There was a problem hiding this comment.
thanks @mokimo - removed this line
There was a problem hiding this comment.
(nitpick) I would label this checkbox as "Hide Event date",
Since it can be used to hide the event date range, not only on-demand :)
There was a problem hiding this comment.
@cmiqueo the requestors asked for the events to still show the dates for upcoming/live - so for clarity I would leave the title as is
| @@ -363,6 +363,7 @@ const UiPanel = () => html` | |||
| <${Input} label="Use Light Text" prop="useLightText" type="checkbox" /> | |||
| <${Input} label="Use Overlay Links" prop="useOverlayLinks" type="checkbox" /> | |||
| <${Input} label="Show total card count at top" prop="showTotalResults" type="checkbox" /> | |||
| <${Input} label="Hide date for on-demand content" prop="hideDateInterval" type="checkbox" /> | |||
There was a problem hiding this comment.
(nitpick) I would label this checkbox as "Hide Event date",
Since it can be used to hide the event date range, not only on-demand :)
|
Skipped merging 2553: MWPW-153167: caas-config change to enable hiding date detail information due to failing checks |
|
Skipped merging 2553: MWPW-153167: caas-config change to enable hiding date detail information due to failing checks |
2 similar comments
|
Skipped merging 2553: MWPW-153167: caas-config change to enable hiding date detail information due to failing checks |
|
Skipped merging 2553: MWPW-153167: caas-config change to enable hiding date detail information due to failing checks |
* stage: Mwpw-142267: Merch What's Included and Merch Mnemonic List (TwP) (adobecom#2554) MWPW-149124 Improve Focus Page for Performance Improvement Tiger Team (adobecom#2391) Correctly send the created PR slacks (adobecom#2566) MWPW-153167: caas-config change to enable hiding date detail information (adobecom#2553) MWPW-152016 - Localization target preview for transcreation (adobecom#2564) Relax CORS restrictions for module imports (adobecom#2549) MWPW-153600 [PEP] loader bar on PEP prompt is seen loaded Left to right in RTL locale (adobecom#2548) MWPW-146962 [milo] Text link behaving like button in FAQ section (adobecom#2530) MWPW-152280 MEP: Only preload fragments that are in the 1st section (adobecom#2525) MWPW-152697 Fix Marketo mobile horizontal scroll (adobecom#2514) MWPW-151513: Search results vanished when user clicks on Marquee CTA:Start free trail (adobecom#2406) MWPW-154013 PEP prompt redirection is broken in stage after the PEP dismissal PR merge (adobecom#2547) MWPW-153962: Introduce maslibs query parameter (adobecom#2544) Central georouting support (adobecom#2531) [MWPW-152278] Avoid empty CSS requests (adobecom#2524) MWPW-152918 Fix Marketo button font (adobecom#2513) # Conflicts: # libs/deps/merch-card.js
Our PMs requested to be able to hide Event Start and Event End data on CaasCards for older on-demand webinar content, so users are not discouraged to learn more about our products. This is a small PR that updates the caas-config to enable authors to make this change on collections.
Resolves: MWPW-153167
Test URLs: