-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PARALLEL parameter in testJobTemplate #2973
Conversation
updated the PARALLEL description
Testing triggered via https://ci.adoptopenjdk.net/view/work-in-progress/job/WIP_Test_Job_Auto_Gen/61 (awaiting executor) Thanks for your PR @abigailsleek - please ensure you have signed the ECA agreement (details at: https://www.eclipse.org/legal/ECA.php), noting the email used in the Eclipse profile needs to match that used for Github ID. |
Thank you Shelley.
Also, can I be assigned the issue #2949? I think this one is easy for me to
jump on next.
On Sun, 10 Oct 2021 at 4:00 PM, Shelley Lambert ***@***.***> wrote:
Testing triggered via
https://ci.adoptopenjdk.net/view/work-in-progress/job/WIP_Test_Job_Auto_Gen/61
(awaiting executor)
Thanks for your PR @abigailsleek <https://github.com/abigailsleek> -
please ensure you have signed the ECA agreement (details at:
https://www.eclipse.org/legal/ECA.php), noting the email used in the
Eclipse profile needs to match that used for Github ID.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2973 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHMKITNXX54RIUXO3EMNMBTUGGS7VANCNFSM5FWRMFWQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
Nneamaka Chalokwu
|
Okay, so this means I updated the wrong parameter. I thought the PARALLEL
parameter was at line 378 of the code. Can you please point me in the right
direction?
On Sun, 10 Oct 2021 at 5:10 PM, Shelley Lambert ***@***.***> wrote:
This change has updated the NUM_MACHINES parameter, instead of the
PARALLEL parameter, so it needs to be updated.
Output from test job generated via WIP_Test_Job_Auto_Gen/61
[image: Screen Shot 2021-10-10 at 12 07 22 PM]
<https://user-images.githubusercontent.com/2836948/136704102-e7e89176-1c10-44b9-b73f-4ce01c9fd6e6.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2973 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHMKITJ32EN7JET6O7TMAEDUGG3IDANCNFSM5FWRMFWQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
Nneamaka Chalokwu
|
buildenv/jenkins/testJobTemplate
Outdated
stringParam('NUM_MACHINES', NUM_MACHINES, '''Optional. It has to be used with PARALLEL=Dynamic or PARALLEL=NodesByIterations<br/> | ||
Use with PARALLEL=Dynamic, NUM_MACHINES cannot be greater than the number of matched nodes on Jenkins<br/> | ||
Use with PARALLEL=NodesByIterations, NUM_MACHINES cannot be greater than 20<br/>''') | ||
stringParam('NUM_MACHINES', NUM_MACHINES, '''Optional. Parallel mode: <br/>None // run test(s) in serial <br/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the NUM_MACHINES parameter, keep the description for this as it was.
stringParam('NUM_MACHINES', NUM_MACHINES, '''Optional. Parallel mode: <br/>None // run test(s) in serial <br/> | |
stringParam('NUM_MACHINES', NUM_MACHINES, '''Optional. It has to be used with PARALLEL=Dynamic or PARALLEL=NodesByIterations<br/> | |
Use with PARALLEL=Dynamic, NUM_MACHINES cannot be greater than the number of matched nodes on Jenkins<br/> | |
Use with PARALLEL=NodesByIterations, NUM_MACHINES cannot be greater than 20<br/>''') |
Thank you. I see my mistake now and I have a clear understanding of what
I’m supposed to do.
I’ll correct it and revert back to you.
On Sun, 10 Oct 2021 at 5:23 PM, Shelley Lambert ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In buildenv/jenkins/testJobTemplate
<#2973 (comment)>:
> @@ -376,9 +376,10 @@ ARCH_OS_LIST.each { ARCH_OS ->
sectionHeaderStyle(sectionHeaderHelpTextStyleCss)
}
choiceParam('PARALLEL', PARALLEL_LIST, "Optional. Parallel mode")
- stringParam('NUM_MACHINES', NUM_MACHINES, '''Optional. It has to be used with PARALLEL=Dynamic or PARALLEL=NodesByIterations<br/>
- Use with PARALLEL=Dynamic, NUM_MACHINES cannot be greater than the number of matched nodes on Jenkins<br/>
- Use with PARALLEL=NodesByIterations, NUM_MACHINES cannot be greater than 20<br/>''')
+ stringParam('NUM_MACHINES', NUM_MACHINES, '''Optional. Parallel mode: <br/>None // run test(s) in serial <br/>
This is the NUM_MACHINES parameter, keep the description for this as it
was.
⬇️ Suggested change
- stringParam('NUM_MACHINES', NUM_MACHINES, '''Optional. Parallel mode: <br/>None // run test(s) in serial <br/>
+ stringParam('NUM_MACHINES', NUM_MACHINES, '''Optional. It has to be used with PARALLEL=Dynamic or PARALLEL=NodesByIterations<br/>
+ Use with PARALLEL=Dynamic, NUM_MACHINES cannot be greater than the number of matched nodes on Jenkins<br/>
+ Use with PARALLEL=NodesByIterations, NUM_MACHINES cannot be greater than 20<br/>''')
------------------------------
In buildenv/jenkins/testJobTemplate
<#2973 (comment)>:
> @@ -376,9 +376,10 @@ ARCH_OS_LIST.each { ARCH_OS ->
sectionHeaderStyle(sectionHeaderHelpTextStyleCss)
}
choiceParam('PARALLEL', PARALLEL_LIST, "Optional. Parallel mode")
This is the PARALLEL parameter.
⬇️ Suggested change
- choiceParam('PARALLEL', PARALLEL_LIST, "Optional. Parallel mode")
+ choiceParam('PARALLEL', PARALLEL_LIST, '''Optional. Parallel mode: <br/>None // run test(s) in serial <br/>
+ Dynamic // dynamically divides tests according to NUM_MACHINES and runs them in parallel. Please also provide NUM_MACHINES. <br/>
+ NodesByIterations // run the same test(s) in parallel according to NUM_MACHINES. You can also provide ITERATIONS. This is mainly for debugging intermittent issues. <br/>
+ Subdir // run tests in parallel according to subdir. This is mainly for external tests.''')
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2973 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHMKITKZ7YKBZ3AMYO6GF5LUGG4ZNANCNFSM5FWRMFWQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
Nneamaka Chalokwu
|
Recently corrected changes made to the PARALLEL description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just updated changes to the PARALLEL description. My previous commit changed the NUM_MACHINES description. This, I have just fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to use 3 single quotes ''' when surrounding a multi-line block (rather than double-quote "). Please see suggested changes inline.
buildenv/jenkins/testJobTemplate
Outdated
@@ -375,7 +375,10 @@ ARCH_OS_LIST.each { ARCH_OS -> | |||
sectionHeader('Additional test options if you wish to run in various parallel modes') | |||
sectionHeaderStyle(sectionHeaderHelpTextStyleCss) | |||
} | |||
choiceParam('PARALLEL', PARALLEL_LIST, "Optional. Parallel mode") | |||
choiceParam('PARALLEL', PARALLEL_LIST, "Optional. Parallel mode: <br/>None // run test(s) in serial <br/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
choiceParam('PARALLEL', PARALLEL_LIST, "Optional. Parallel mode: <br/>None // run test(s) in serial <br/> | |
choiceParam('PARALLEL', PARALLEL_LIST, '''Optional. Parallel mode: <br/>None // run test(s) in serial <br/> |
buildenv/jenkins/testJobTemplate
Outdated
choiceParam('PARALLEL', PARALLEL_LIST, "Optional. Parallel mode: <br/>None // run test(s) in serial <br/> | ||
Dynamic // dynamically divides tests according to NUM_MACHINES and runs them in parallel. Please also provide NUM_MACHINES. <br/> | ||
NodesByIterations // run the same test(s) in parallel according to NUM_MACHINES. You can also provide ITERATIONS. This is mainly for debugging intermittent issues. <br/> | ||
Subdir // run tests in parallel according to subdir. This is mainly for external tests.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Subdir // run tests in parallel according to subdir. This is mainly for external tests.") | |
Subdir // run tests in parallel according to subdir. This is mainly for external tests.<br/>''') |
New test triggered via: https://ci.adoptopenjdk.net/view/work-in-progress/job/WIP_Test_Job_Auto_Gen/62 indicates an issue:
Suggesting to start the block with |
* finish adding GIT_ISSUE_STATUS to the json * add error handling * delete output file * change the name of input file * change the common.xml * fix the then * change the to outputproperty in common.xm; * add the error msg * handle the case if branch not exit go to origin/branch * solve the nested echo problem * remove the change relaed to adoptium#2882 * move the if inside * accept sha for openjdk_systemtest * accept sha for openj9-systemtest * get rid of repetetive code for cloneing stf * fix the outputproperty unable to overwrite * revert the change * fixfix the outputproperty unable to overwrite for systemtest * fix formatting * change the logic for the openjdk system test * change logic for openj9-systemtest * fix no ending if * fix failonerror * fix the return * change the name of sha
Signed-off-by: Jason Feng <fengj@ca.ibm.com>
Signed-off-by: Mesbah-Alam <Mesbah_Alam@ca.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The resulting generated test job looks good. Would prefer not to pull in all the whitespace changes come in with this PR.
Okay, thank you. How can I fix the white spaces?
On Wed, 13 Oct 2021 at 2:12 AM, Shelley Lambert ***@***.***> wrote:
***@***.**** commented on this pull request.
The resulting generated test job looks good. Would prefer not to pull in
all the whitespace changes come in with this PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2973 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHMKITJ2XMNHDSNYA2TOQ53UGTMJBANCNFSM5FWRMFWQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
Nneamaka Chalokwu
|
…doptium#2894) Signed-off-by: Paul Saunders <44712655+psaunderualberta@users.noreply.github.com>
Signed-off-by: renfeiw <renfeiw@ca.ibm.com>
…dows-x86 (adoptium#2998) * Update ProblemList_openjdk17.txt * Update ProblemList_openjdk17.txt
* add sainamercy to conributing list * Exclude 2 jfr testcases on aarch64 platform * Revert "Revert "add sainamercy to conributing list"" This reverts commit ade06be.
…doptium#2981) * Switch api query back to AdoptOpenjdk for openj9 jdk
… external category (adoptium#2972) * Update test.properties
adoptium#3010) Signed-off-by: Mesbah-Alam <Mesbah_Alam@ca.ibm.com>
I need to delete this file, then commit using a separate pull request
* Exclude 2 tests on window32 with jdk17 * Exclude 2 tests on window32 with jdk17 * Update ProblemList_openjdk17-openj9.txt * Update ProblemList_openjdk17.txt
…ws-x86" (adoptium#3006) * Update ProblemList_openjdk17.txt * Update ProblemList_openjdk17.txt Fix adoptium#3004 * Update ProblemList_openjdk17.txt for windows-x86 platform * Update ProblemList_openjdk17.txt * Update ProblemList_openjdk17.txt * Update ProblemList_openjdk17.txt
Hi Shelley, I made another commit where I fixed the white spaces. Please
review thank you.
On Wed, 13 Oct 2021 at 9:29 AM, Nneamaka Chalokwu ***@***.***>
wrote:
Okay, thank you. How can I fix the white spaces?
On Wed, 13 Oct 2021 at 2:12 AM, Shelley Lambert ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
>
> The resulting generated test job looks good. Would prefer not to pull in
> all the whitespace changes come in with this PR.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#2973 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AHMKITJ2XMNHDSNYA2TOQ53UGTMJBANCNFSM5FWRMFWQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
Nneamaka Chalokwu
--
Nneamaka Chalokwu
|
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Mesbah-Alam <Mesbah_Alam@ca.ibm.com>
) Related: adoptium/aqa-test-tools#569 Signed-off-by: lanxia <lan_xia@ca.ibm.com>
Signed-off-by: Mesbah-Alam <Mesbah_Alam@ca.ibm.com>
…3008) * enhance the function getProperty() to deal with quotations reword removed the echo in getProperty() reword removed the logic of parsing and removing the quotes in set_test_info() reword updated set_test_info() updated set_test_info() to resolve conflict * modified set_test_info() * modified line 226
Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
- Add jdk_lang_VarHandleTest_j9 test with specific jit option Signed-off-by: Longyu Zhang <longyu.zhang@ibm.com>
- VarHandleTestAccess tests fails for jdk17, so exclude them temporarily - These tests will be moved to a new test with specific jit options Signed-off-by: Longyu Zhang <longyu.zhang@ibm.com>
* Removed JRE_IMAGE in openjdk.mk * Added DYNAMIC_COMPILE in testJobTemplate adoptium#3031 * Update testJobTemplate Removed the DYNAMIC_COMPILE and its description after BUILD_LIST in testJobTemplate
…tium#3104) Signed-off-by: Mesbah-Alam <Mesbah_Alam@ca.ibm.com>
…m#3105) Signed-off-by: Mesbah-Alam <Mesbah_Alam@ca.ibm.com>
Guidance for ECA since this PR still fails the ECA check: |
I will close this PR as stale. It may be best to start with a fresh branch after signing the ECA should you want to return to this @abigailsleek . Thanks. |
I just updated the PARALLEL description in the testjobTemplate.