Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting CUSTOMIZED_SDK_URL and SDK_RESOURCES as non customized ignores the SDK_RESOURCE value #3099

Closed
wants to merge 22 commits into from

Conversation

abigailsleek
Copy link

@abigailsleek abigailsleek commented Oct 26, 2021

Fixes #2097
updated CUSTOMIZED_ SDK_URL and SDK_RESOURCE

abigailsleek and others added 6 commits October 10, 2021 15:37

Verified

This commit was signed with the committer’s verified signature.
matteodepalo Matteo Depalo
updated the PARALLEL description
Recently corrected changes made to the PARALLEL description.
I need to delete this file, then commit using a separate pull request
@abigailsleek abigailsleek changed the title Sub1 Setting CUSTOMIZED_SDK_URL and SDK_RESOURCES as non customized ignores the SDK_RESOURCE value Oct 26, 2021
@sophia-guo
Copy link
Contributor

@abigailsleek you probably have a different configuration of the file format? I can't see your changes.

Mesbah-Alam and others added 3 commits October 26, 2021 16:42
Signed-off-by: Mesbah-Alam <Mesbah_Alam@ca.ibm.com>
Signed-off-by: Mesbah-Alam <Mesbah_Alam@ca.ibm.com>
timestamps{
setupEnv()

if (params.SDK_RESOURCE == 'nightly' && params.CUSTOMIZED_SDK_URL) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I effected changes from line 358 to line 368. Do you mean the file is not opening at your end or the changes I made is not reflecting?
Please how can I go about fixing this.

xius666 and others added 2 commits October 27, 2021 08:42
…3008)

* enhance the function getProperty() to deal with quotations

reword removed the echo  in getProperty()

reword removed the logic of parsing and removing the quotes in set_test_info()

reword updated set_test_info()

updated set_test_info() to resolve conflict

* modified set_test_info()

* modified line 226
@sophia-guo
Copy link
Contributor

@abigailsleek as we mentioned in the adoptium community call that your IDE may have some different text formats about space or tab, which changed the whole files.

sectionHeader('Additional test options if you wish to run in various parallel modes')
sectionHeaderStyle(sectionHeaderHelpTextStyleCss)
}
choiceParam('PARALLEL', PARALLEL_LIST, '''Optional. Parallel mode: <br/>None // run test(s) in serial <br/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this change should not be in this PR? Rebase your PR may help.

keithc-ca and others added 11 commits October 27, 2021 12:19
Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
- Add jdk_lang_VarHandleTest_j9 test with specific jit option

Signed-off-by: Longyu Zhang <longyu.zhang@ibm.com>
- VarHandleTestAccess tests fails for jdk17, so exclude them temporarily
- These tests will be moved to a new test with specific jit options

Signed-off-by: Longyu Zhang <longyu.zhang@ibm.com>
* Removed JRE_IMAGE in openjdk.mk

* Added DYNAMIC_COMPILE in testJobTemplate adoptium#3031

* Update testJobTemplate

Removed the DYNAMIC_COMPILE and its description after BUILD_LIST in testJobTemplate
…m#3105)

Signed-off-by: Mesbah-Alam <Mesbah_Alam@ca.ibm.com>
@sophia-guo
Copy link
Contributor

Rebase is still needed. Looks like your PR includes other's merged PRs.

@smlambert
Copy link
Contributor

Closing this as stale, if you'd like to return to it, may be best to create a fresh up-to-date branch and not carry the whitespace changes that were present in this branch.

@smlambert smlambert closed this Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting CUSTOMIZED_SDK_URL and SDK_RESOURCE as non-customized ignores the SDK_RESOURCE value