Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not freeze when downloading the logs #1693

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Conversation

imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Oct 23, 2024

Problem

If you try to download the logs using the web UI, agama-web-server gets unresponsive.

Solution

  • Use tokio::process::Command to download the logs.
  • Rename the endpoint to reflect the file format.

To do

  • The UI is not properly adapted yet but @dgdavid is working on it.

@imobachgs imobachgs marked this pull request as ready for review October 23, 2024 15:30
Copy link
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@imobachgs imobachgs merged commit b2eafff into master Oct 23, 2024
6 checks passed
@imobachgs imobachgs deleted the fix-fetch-logs branch October 23, 2024 15:38
@coveralls
Copy link

coveralls commented Oct 23, 2024

Pull Request Test Coverage Report for Build 11483204391

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 71.39%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rust/agama-server/src/manager/web.rs 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
rust/agama-server/src/manager/web.rs 1 0.0%
Totals Coverage Status
Change from base Build 11460749266: -0.003%
Covered Lines: 16883
Relevant Lines: 23649

💛 - Coveralls

dgdavid added a commit that referenced this pull request Oct 23, 2024
By using a plain old HTML link pointing to api/manager/logs.tar.gz after
changes introduced at #1693.
dgdavid added a commit that referenced this pull request Oct 23, 2024
By using a plain old HTML link pointing to api/manager/logs.tar.gz after
changes introduced at #1693.
dgdavid added a commit that referenced this pull request Oct 23, 2024
By using a plain old HTML link pointing to api/manager/logs.tar.gz after
changes introduced at #1693.
imobachgs added a commit that referenced this pull request Oct 23, 2024
## Problem 

After changes introduced in
#1693, the `LogsButton`
component has become obsolete and does not work as expected.

## Solution

Use an old plain HTML link pointing to the expected URL and using the
[download](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#download)
attribute.

## Additional note

Please, bear in mind that this is kind of intermediate change to make
the link work again. It will be superseded (and probably improved) by
the WIP #1690

## Testing

- Tested manually
@imobachgs imobachgs mentioned this pull request Jan 10, 2025
imobachgs added a commit that referenced this pull request Jan 13, 2025
Update to release version 11.

* #1495
* #1564
* #1617
* #1618
* #1625
* #1626
* #1627
* #1628
* #1630
* #1631
* #1632
* #1633
* #1634
* #1635
* #1636
* #1639
* #1640
* #1641
* #1642
* #1643
* #1644
* #1645
* #1646
* #1647
* #1648
* #1649
* #1650
* #1651
* #1652
* #1654
* #1655
* #1656
* #1657
* #1660
* #1663
* #1666
* #1667
* #1668
* #1670
* #1671
* #1673
* #1674
* #1675
* #1676
* #1677
* #1681
* #1682
* #1683
* #1684
* #1687
* #1688
* #1689
* #1690
* #1691
* #1692
* #1693
* #1694
* #1695
* #1696
* #1698
* #1699
* #1702
* #1703
* #1704
* #1705
* #1707
* #1708
* #1709
* #1710
* #1711
* #1712
* #1713
* #1714
* #1715
* #1716
* #1717
* #1718
* #1720
* #1721
* #1722
* #1723
* #1727
* #1728
* #1729
* #1731
* #1732
* #1733
* #1734
* #1735
* #1736
* #1737
* #1740
* #1741
* #1743
* #1744
* #1745
* #1746
* #1751
* #1753
* #1754
* #1755
* #1757
* #1762
* #1763
* #1764
* #1765
* #1766
* #1767
* #1769
* #1771
* #1772
* #1773
* #1774
* #1777
* #1778
* #1785
* #1786
* #1787
* #1788
* #1789
* #1790
* #1791
* #1792
* #1793
* #1794
* #1795
* #1796
* #1797
* #1798
* #1799
* #1800
* #1802
* #1803
* #1804
* #1805
* #1807
* #1808
* #1809
* #1810
* #1811
* #1812
* #1814
* #1815
* #1821
* #1822
* #1823
* #1824
* #1825
* #1826
* #1827
* #1828
* #1830
* #1831
* #1832
* #1833
* #1834
* #1835
* #1836
* #1837
* #1838
* #1839
* #1840
* #1841
* #1842
* #1843
* #1844
* #1845
* #1847
* #1848
* #1849
* #1850
* #1851
* #1854
* #1855
* #1856
* #1857
* #1860
* #1861
* #1863
* #1864
* #1865
* #1866
* #1867
* #1871
* #1872
* #1873
* #1875
* #1876
* #1877
* #1878
* #1880
* #1881
* #1882
* #1883
* #1884
* #1885
* #1886
* #1888
* #1889
* #1890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants