Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
There were basically two problems:
ath11k/WCN6855/hw2.1/*
. That was not supported by the script, it expected only individual file names referenced by drivers.foo.bin
file but in some cases it is actually a symlink pointing tofoo-1.0.bin
. The script then deleted thefoo-1.0.bin
file as it looked like not used by drivers. The result was a dangling symlink and a missing firmware file.Both issues were fixed. The glob patterns are evaluated using the
Dir.glob
function and if the referenced file is a symlink then it also keeps the target file where the symlink points to.Testing