fix: Remove OpenSSL dependency, use Rust TLS

[grahamking]

Introduced here: #1934

cargo deny normally prevents this but it wasn't being enforced last night.

We avoid OpenSSL because:

• It needs to be dynamically linked, so we have to build for a specific version.
• We have to stay on top of CVEs. The Rust TLS is considered more secure.
• It interferes with other libraries trying to do static linking. For example we cannot statically link llama.cpp if we dynamically link OpenSSL.

Summary by CodeRabbit

• Chores
  • Updated and refined development dependencies to improve compatibility and security.
  • Adjusted dependency features to enhance streaming and secure connection support.

[coderabbitai]

Walkthrough

The changes update the reqwest crate configuration in the Cargo.toml files for two separate library components. The version is specified more precisely in one file, and feature flags are explicitly set in another, ensuring consistent dependency management and feature usage for development purposes.

Changes

File(s)	Change Summary
lib/llm/Cargo.toml	Updated reqwest dev-dependency version from "0.12" to "0.12.22" with unchanged feature flags.
lib/runtime/Cargo.toml	Modified reqwest dev-dependency to disable default features and enable json, stream, and rustls-tls features, version remains "0.12.22".

Poem

In the warren of code where dependencies dwell,
We sharpened our specs and features as well.
With reqwest now clearer, our builds hop with glee—
Rustls and streams, as safe as can be!
🐇✨

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

lib/llm/Cargo.toml (1)

136-136: Deduplicate identical reqwest stanza via workspace-level dependency

Both dynamo-runtime and dynamo-llm now carry the same reqwest declaration.
Move it to [workspace.dependencies] (root Cargo.toml) and reference it with workspace = true to avoid drift:

# root Cargo.toml
[workspace.dependencies]
reqwest = { version = "0.12.22", default-features = false, features = ["json", "stream", "rustls-tls"] }

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3c6fc6f and 06f3e18.

⛔ Files ignored due to path filters (1)

• Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (2)

• lib/llm/Cargo.toml (1 hunks)
• lib/runtime/Cargo.toml (1 hunks)

🧰 Additional context used

🧠 Learnings (3)

📓 Common learnings

Learnt from: kthui
PR: ai-dynamo/dynamo#1424
File: lib/runtime/src/pipeline/network/egress/push_router.rs:204-209
Timestamp: 2025-06-13T22:07:24.843Z
Learning: The codebase uses async-nats version 0.40, not the older nats crate. Error handling should use async_nats::error::Error variants, not nats::Error variants.

Learnt from: ryanolson
PR: ai-dynamo/dynamo#1919
File: lib/runtime/src/engine.rs:168-168
Timestamp: 2025-07-14T21:25:56.898Z
Learning: The AsyncEngineContextProvider trait in lib/runtime/src/engine.rs was intentionally changed from `Send + Sync + Debug` to `Send + Debug` because the Sync bound was overly constraining. The trait should only require Send + Debug as designed.

lib/runtime/Cargo.toml (1)

Learnt from: kthui
PR: ai-dynamo/dynamo#1424
File: lib/runtime/src/pipeline/network/egress/push_router.rs:204-209
Timestamp: 2025-06-13T22:07:24.843Z
Learning: The codebase uses async-nats version 0.40, not the older nats crate. Error handling should use async_nats::error::Error variants, not nats::Error variants.

lib/llm/Cargo.toml (1)

Learnt from: kthui
PR: ai-dynamo/dynamo#1424
File: lib/runtime/src/pipeline/network/egress/push_router.rs:204-209
Timestamp: 2025-06-13T22:07:24.843Z
Learning: The codebase uses async-nats version 0.40, not the older nats crate. Error handling should use async_nats::error::Error variants, not nats::Error variants.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: pre-merge-rust (lib/runtime/examples)
• GitHub Check: pre-merge-rust (.)
• GitHub Check: pre-merge-rust (lib/bindings/python)
• GitHub Check: Build and Test - vllm

🔇 Additional comments (1)

lib/runtime/Cargo.toml (1)

80-80: No existing compressed-response usage detected

Disabling default-features on reqwest does indeed remove gzip, brotli, and deflate support. However, a search for Content-Encoding, gzip, brotli, and deflate across the codebase (including tests) found no references to compressed responses. You can safely keep default-features = false as-is.

If you later need to handle compressed responses, re-enable the appropriate feature(s), for example:

reqwest = { version = "0.12.22", default-features = false, features = ["json", "stream", "rustls-tls", "gzip"] }