MongoDb Source: Increase performance of discover #17614

VitaliiMaltsev · 2022-10-05T16:06:52Z

What

Performance of schema discover could be very slow for big datasets in Mongo db

How

Execute in parallel

Server response
Before

After

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

VitaliiMaltsev · 2022-10-05T16:08:28Z

/test connector=connectors/source-mongodb-v2

🕑 connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/3191186688
✅ connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/3191186688
No Python unittests run

Build Passed

Test summary info:

All Passed

grishick · 2022-10-05T21:48:49Z

@VitaliiMaltsev do you have a before and after comparison to document how much improvement this change is adding?

VitaliiMaltsev · 2022-10-05T21:54:28Z

@VitaliiMaltsev do you have a before and after comparison to document how much improvement this change is adding?

@grishick parallelStream by default used number of processors -1 thread. Tested on my local env - with parallelStream discover is approximately 4x faster

VitaliiMaltsev · 2022-10-06T09:53:06Z

added screenshots with timing comparison

grishick · 2022-10-06T19:56:10Z

LGTM, please rebase (or merge) and make sure tests still pass after rebase/merge

# Conflicts: # airbyte-integrations/connectors/source-mongodb-v2/src/main/java/io.airbyte.integrations.source.mongodb/MongoDbSource.java

VitaliiMaltsev · 2022-10-07T06:06:12Z

/test connector=connectors/source-mongodb-v2

🕑 connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/3202630332
✅ connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/3202630332
No Python unittests run

Build Passed

Test summary info:

All Passed

github-actions · 2022-10-07T06:06:21Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

source-mongodb-strict-encrypt
source-mongodb-v2

github-actions · 2022-10-07T10:05:46Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

source-mongodb-strict-encrypt
source-mongodb-v2

github-actions · 2022-10-07T10:24:42Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

source-mongodb-v2
source-mongodb-strict-encrypt

VitaliiMaltsev · 2022-10-07T10:44:28Z

/publish connector=connectors/source-mongodb-v2

🕑 Publishing the following connectors:
connectors/source-mongodb-v2
https://github.com/airbytehq/airbyte/actions/runs/3204140956

Connector	Did it publish?	Were definitions generated?
connectors/source-mongodb-v2	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

VitaliiMaltsev · 2022-10-07T11:06:06Z

/publish connector=connectors/source-mongodb-strict-encrypt

🕑 Publishing the following connectors:
connectors/source-mongodb-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/3204260105

Connector	Did it publish?	Were definitions generated?
connectors/source-mongodb-strict-encrypt	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…vation * master: (32 commits) fixed octavia position and z-index on onboarding page (#17708) Revert "Revert "Do not wait the end of a reset to return an update (#17591)" (#17640)" (#17669) source-google-analytics-v4: use hits metric for check (#17717) Source linkedin-ads: retry 429/5xx when refreshing access token (#17724) 🐛 Source Mixpanel: solve cursor field none expected array (#17699) 🎉 8890 Source MySql: Fix large table issue by fetch size (#17236) Test e2e testing tool commands (#17722) fixed escape character i18n error (#17706) Docs: adds missing " in transformations-with-airbyte.md (#17723) Change Osano token to new project (#17720) Source Github: improve 502 handling for `comments` stream (#17715) #17506 source snapchat marketing: retry failed request for refreshing access token (#17596) MongoDb Source: Increase performance of discover (#17614) Testing tool commands for run scenarios (#17550) Kustomize: Missing NORMALIZATION_JOB_* environment variables in stable-with-resource-limits overlays (#17713) Fix console errors (#17696) Revert: #17047 Airbyte CDK: Improve error for returning non-iterable from connectors parse_response (#17707) #17047 Airbyte CDK: Improve error for returning non-iterable from connectors parse_response (#17626) 📝 Postgres source: document occasional full refresh under cdc mode (#17705) Bump Airbyte version from 0.40.12 to 0.40.13 (#17682) ...

* MongoDb Source: Increase performance of discover * bump version * fixed tests * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

MongoDb Source: Increase performance of discover

a0747b8

VitaliiMaltsev requested a review from grishick October 5, 2022 16:08

VitaliiMaltsev mentioned this pull request Oct 5, 2022

Source MongoDB: Failed to fetch Schema #14246

Open

grishick approved these changes Oct 6, 2022

View reviewed changes

Merge branch 'master' into vmaltsev/14246-mongo-source-parallel-discover

ea3ba17

# Conflicts: # airbyte-integrations/connectors/source-mongodb-v2/src/main/java/io.airbyte.integrations.source.mongodb/MongoDbSource.java

github-actions bot added the area/connectors Connector related issues label Oct 7, 2022

octavia-squidington-iv added the connectors/source/mongodb-v2 label Oct 7, 2022

bump version

b7de40e

github-actions bot added the area/documentation Improvements or additions to documentation label Oct 7, 2022

octavia-squidington-iv added the connectors/source/mongodb-strict-encrypt label Oct 7, 2022

fixed tests

6bda00f

auto-bump connector version [ci skip]

7f86495

VitaliiMaltsev merged commit 84f0299 into master Oct 7, 2022

VitaliiMaltsev deleted the vmaltsev/14246-mongo-source-parallel-discover branch October 7, 2022 11:18

octavia-squidington-iii mentioned this pull request Oct 7, 2022

Bump Airbyte version from 0.40.13 to 0.40.14 #17762

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MongoDb Source: Increase performance of discover #17614

MongoDb Source: Increase performance of discover #17614

VitaliiMaltsev commented Oct 5, 2022 •

edited

Loading

VitaliiMaltsev commented Oct 5, 2022 •

edited by github-actions bot

Loading

grishick commented Oct 5, 2022

VitaliiMaltsev commented Oct 5, 2022

VitaliiMaltsev commented Oct 6, 2022

grishick commented Oct 6, 2022

VitaliiMaltsev commented Oct 7, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Oct 7, 2022

github-actions bot commented Oct 7, 2022

github-actions bot commented Oct 7, 2022

VitaliiMaltsev commented Oct 7, 2022 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Oct 7, 2022 •

edited by github-actions bot

Loading

MongoDb Source: Increase performance of discover #17614

MongoDb Source: Increase performance of discover #17614

Conversation

VitaliiMaltsev commented Oct 5, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

VitaliiMaltsev commented Oct 5, 2022 • edited by github-actions bot Loading

Build Passed

grishick commented Oct 5, 2022

VitaliiMaltsev commented Oct 5, 2022

VitaliiMaltsev commented Oct 6, 2022

grishick commented Oct 6, 2022

VitaliiMaltsev commented Oct 7, 2022 • edited by github-actions bot Loading

Build Passed

github-actions bot commented Oct 7, 2022

github-actions bot commented Oct 7, 2022

github-actions bot commented Oct 7, 2022

VitaliiMaltsev commented Oct 7, 2022 • edited by github-actions bot Loading

VitaliiMaltsev commented Oct 7, 2022 • edited by github-actions bot Loading

VitaliiMaltsev commented Oct 5, 2022 •

edited

Loading

VitaliiMaltsev commented Oct 5, 2022 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Oct 7, 2022 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Oct 7, 2022 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Oct 7, 2022 •

edited by github-actions bot

Loading