🐛 Source Mixpanel: solve cursor field none expected array #17699

marcosmarxm · 2022-10-06T20:47:27Z

What

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

marcosmarxm · 2022-10-06T20:49:21Z

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/3200376400
❌ connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/3200376400
🐛 https://gradle.com/s/q6gabxubmjnlc

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
================== 1 failed, 30 passed in 1903.30s (0:31:43) ===================

sh4sh

Looks good to me!

marcosmarxm · 2022-10-06T23:54:41Z

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/3201259210
❌ connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/3201259210
🐛 https://gradle.com/s/z5zrqmff5emyg

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - AssertionError: as...
FAILED test_core.py::TestConnection::test_check[inputs1] - AssertionError: as...
FAILED test_core.py::TestConnection::test_check[inputs2] - AssertionError: as...
FAILED test_core.py::TestDiscovery::test_discover[inputs0] - Failed: Timeout ...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
============= 4 failed, 24 passed, 3 errors in 4737.24s (1:18:57) ==============

marcosmarxm · 2022-10-07T10:29:43Z

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/3204063397
✅ connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/3204063397
Python tests coverage:

Name                                         Stmts   Miss  Cover
----------------------------------------------------------------
source_mixpanel/utils.py                         8      0   100%
source_mixpanel/streams/revenue.py              14      0   100%
source_mixpanel/streams/funnels.py              57      0   100%
source_mixpanel/streams/cohorts.py              15      0   100%
source_mixpanel/streams/__init__.py              9      0   100%
source_mixpanel/property_transformation.py      19      0   100%
source_mixpanel/__init__.py                      2      0   100%
source_mixpanel/streams/export.py               55      1    98%
source_mixpanel/streams/base.py                 89      2    98%
source_mixpanel/streams/engage.py               88      6    93%
source_mixpanel/source.py                       79     10    87%
source_mixpanel/streams/annotations.py          16      3    81%
source_mixpanel/streams/cohort_members.py       21      7    67%
source_mixpanel/testing.py                      29     11    62%
----------------------------------------------------------------
TOTAL                                          501     40    92%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       152     26    83%   21-23, 29-31, 36-43, 48-61, 239, 250-258
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-67, 70-72, 75-77, 80-82, 85-87, 90-92, 95-113, 147-149
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1358    466    66%

Build Passed

Test summary info:

All Passed

marcosmarxm · 2022-10-07T11:30:52Z

/publish connector=connectors/source-mixpanel

🕑 Publishing the following connectors:
connectors/source-mixpanel
https://github.com/airbytehq/airbyte/actions/runs/3204400688

Connector	Did it publish?	Were definitions generated?
connectors/source-mixpanel	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…vation * master: (32 commits) fixed octavia position and z-index on onboarding page (#17708) Revert "Revert "Do not wait the end of a reset to return an update (#17591)" (#17640)" (#17669) source-google-analytics-v4: use hits metric for check (#17717) Source linkedin-ads: retry 429/5xx when refreshing access token (#17724) 🐛 Source Mixpanel: solve cursor field none expected array (#17699) 🎉 8890 Source MySql: Fix large table issue by fetch size (#17236) Test e2e testing tool commands (#17722) fixed escape character i18n error (#17706) Docs: adds missing " in transformations-with-airbyte.md (#17723) Change Osano token to new project (#17720) Source Github: improve 502 handling for `comments` stream (#17715) #17506 source snapchat marketing: retry failed request for refreshing access token (#17596) MongoDb Source: Increase performance of discover (#17614) Testing tool commands for run scenarios (#17550) Kustomize: Missing NORMALIZATION_JOB_* environment variables in stable-with-resource-limits overlays (#17713) Fix console errors (#17696) Revert: #17047 Airbyte CDK: Improve error for returning non-iterable from connectors parse_response (#17707) #17047 Airbyte CDK: Improve error for returning non-iterable from connectors parse_response (#17626) 📝 Postgres source: document occasional full refresh under cdc mode (#17705) Bump Airbyte version from 0.40.12 to 0.40.13 (#17682) ...

…17699) * solve cursor field none expected array * update doc * correct cursor_field * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

solve cursor field none expected array

f7fd31e

marcosmarxm requested review from grubberr, sh4sh and natalyjazzviolin October 6, 2022 20:47

github-actions bot added the area/connectors Connector related issues label Oct 6, 2022

octavia-squidington-iv added the connectors/source/mixpanel label Oct 6, 2022

update doc

dcd9d80

github-actions bot added the area/documentation Improvements or additions to documentation label Oct 6, 2022

marcosmarxm changed the title ~~solve cursor field none expected array~~ 🐛 Source Mixpanel: solve cursor field none expected array Oct 6, 2022

sh4sh force-pushed the marcos/mixpanel-cursor-field-none branch from dcd9d80 to 63906e5 Compare October 6, 2022 22:43

sh4sh approved these changes Oct 6, 2022

View reviewed changes

correct cursor_field

2c1654b

marcosmarxm force-pushed the marcos/mixpanel-cursor-field-none branch from 63906e5 to 2c1654b Compare October 6, 2022 23:54

auto-bump connector version [ci skip]

f391ea0

marcosmarxm merged commit c4f6cbe into master Oct 7, 2022

marcosmarxm deleted the marcos/mixpanel-cursor-field-none branch October 7, 2022 13:34

octavia-squidington-iii mentioned this pull request Oct 7, 2022

Bump Airbyte version from 0.40.13 to 0.40.14 #17762

Merged

evantahler mentioned this pull request Mar 17, 2023

Source Mixpanel: default_cursor_field: null found, array expected #17373

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Source Mixpanel: solve cursor field none expected array #17699

🐛 Source Mixpanel: solve cursor field none expected array #17699

marcosmarxm commented Oct 6, 2022

marcosmarxm commented Oct 6, 2022 •

edited by github-actions bot

Loading

sh4sh left a comment

marcosmarxm commented Oct 6, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Oct 7, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Oct 7, 2022 •

edited by github-actions bot

Loading

🐛 Source Mixpanel: solve cursor field none expected array #17699

🐛 Source Mixpanel: solve cursor field none expected array #17699

Conversation

marcosmarxm commented Oct 6, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

marcosmarxm commented Oct 6, 2022 • edited by github-actions bot Loading

Build Failed

sh4sh left a comment

Choose a reason for hiding this comment

marcosmarxm commented Oct 6, 2022 • edited by github-actions bot Loading

Build Failed

marcosmarxm commented Oct 7, 2022 • edited by github-actions bot Loading

Build Passed

marcosmarxm commented Oct 7, 2022 • edited by github-actions bot Loading

marcosmarxm commented Oct 6, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Oct 6, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Oct 7, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Oct 7, 2022 •

edited by github-actions bot

Loading