Test e2e testing tool commands #17722

andriikorotkov · 2022-10-07T11:11:43Z

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

…test_testing_tool_command � Conflicts: � .github/workflows/help-full-command.yml

…test_testing_tool_command

andriikorotkov · 2022-10-07T11:13:03Z

/help-full name="Update destination version scenario"

✅ https://github.com/airbytehq/airbyte/actions/runs/3204299111

Scenario `Update destination version scenario`. ✔️

ℹ️ Configure default connection, set destination version. After sync, update version and repeat sync

Call examples :

Run scenario : /run-scenario name="Update destination version scenario" airbyte_1=<put_credential_name> source_1=<put_credential_name> destination_1=<put_credential_name> old_version=<parameter_value> new_version=<parameter_value>
Run scenario with local creds : /run-scenario-local name="Update destination version scenario" airbyte_1=<put_credential_name> source_1=<put_credential_name> destination_1=<put_credential_name> old_version=<parameter_value> new_version=<parameter_value>
Note! The local scenario run requires file names in the folder secrets\. For example, some_cred_1=local_file.json
Get short help : /help name="Update destination version scenario"

Instances in the scenario

name : airbyte_1
type : AIRBYTE
credentials : airbyte_creds
name : source_1
type : SOURCE
credentials : source_creds
name : destination_1
type : DESTINATION
credentials : destination_creds
name : connection_1
type : CONNECTION

Parameters in the scenario

name : old_version
type : destination_version
name : new_version
type : destination_version

Scenario actions

Preparation actions :

action : CONNECT_AIRBYTE_API
resultInstance : airbyte_1
action : CREATE_SOURCE
requiredInstances : [airbyte_1]
resultInstance : source_1
action : CREATE_DESTINATION
requiredInstances : [airbyte_1]
resultInstance : destination_1
action : READ_DESTINATION_VERSION
requiredInstances : [destination_1]
action : UPDATE_DESTINATION_VERSION
requiredInstances : [destination_1]
requiredParameters : [old_version]
action : CREATE_CONNECTION
requiredInstances : [source_1, destination_1]
resultInstance : connection_1

Scenario actions :

action : SYNC_CONNECTION
requiredInstances : [connection_1]
action : UPDATE_DESTINATION_VERSION
requiredInstances : [destination_1]
requiredParameters : [new_version]
action : SYNC_CONNECTION
requiredInstances : [connection_1]
action : UPDATE_DESTINATION_VERSION
requiredInstances : [destination_1]
requiredParameters : [before_test_version]

andriikorotkov · 2022-10-07T11:14:48Z

/help name="Test invalid scenario"

✅ https://github.com/airbytehq/airbyte/actions/runs/3204308025

Scenario `Test invalid scenario`. ❌

ℹ️ The scenario contains logical gap for the demo purposes

⚠️ Failed validations :

Validation	Result
Check that all instances have initialization action	Instance(s) that should be initialized by an action : airbyte_1
Check that all action instances listed in the `UsedInstances` section	Instance(s) used in the scenario actions but not described in the UsedInstances : airbyte_2
Action should have all mandatory attributes	The action CONNECT_AIRBYTE_API should have result instance : [AIRBYTE] but have : []

Call examples :

Run scenario : /run-scenario name="Test invalid scenario" airbyte_1=<put_credential_name> source_1=<put_credential_name> destination_1=<put_credential_name> new_version=<parameter_value> old_version=<parameter_value>
Run scenario with local creds : /run-scenario-local name="Test invalid scenario" airbyte_1=<put_credential_name> source_1=<put_credential_name> destination_1=<put_credential_name> new_version=<parameter_value> old_version=<parameter_value>
Note! The local scenario run requires file names in the folder secrets\. For example, some_cred_1=local_file.json
Get full help : /help-full name="Test invalid scenario"

Instances in the scenario

name : airbyte_1
type : AIRBYTE
credentials : airbyte_creds
name : source_1
type : SOURCE
credentials : source_creds
name : destination_1
type : DESTINATION
credentials : destination_creds
name : connection_1
type : CONNECTION

Parameters in the scenario

name : new_version
type : source_version
name : old_version
type : source_version

andriikorotkov · 2022-10-07T11:16:17Z

/list-scenarios

✅ https://github.com/airbytehq/airbyte/actions/runs/3204316314

Call help examples :

Get short help : /help name="<scenario_name>"
Get full help : /help-full name="<scenario_name>"

Scenario validation sings :

✔️ - the scenario is valid and ready for use.
❌ - the scenario is invalid. You can get a list of errors by a help command.

Available scenarios :

Custom connection sync scenario ✔️
ℹ️ Configure custom connection using source settings and sync it.
Simple sync scenario ✔️
ℹ️ Sync default connection.
Test invalid scenario ❌
ℹ️ The scenario contains logical gap for the demo purposes
Update destination version scenario ✔️
ℹ️ Configure default connection, set destination version. After sync, update version and repeat sync
Update source version scenario ✔️
ℹ️ Configure default connection, set source version. After sync, update version and repeat sync

andriikorotkov · 2022-10-07T11:17:40Z

/run-scenario name="Update destination version scenario" airbyte_1=tt_airbyte_dev2 source_1=tt_postgres_source_aws_1 destination_1=tt_postgres_destination_aws_1 old_version="0.3.22" new_version="0.3.23"

❌ https://github.com/airbytehq/airbyte/actions/runs/3204324207

andriikorotkov · 2022-10-07T11:20:59Z

/run-scenario name="Update destination version scenario" airbyte_1=tt_airbyte_docker_2 source_1=tt_postgres_source_aws_1 destination_1=tt_postgres_destination_aws_1 old_version="0.3.22" new_version="0.3.23"

❌ https://github.com/airbytehq/airbyte/actions/runs/3204343574

andriikorotkov · 2022-10-07T11:25:59Z

/run-scenario name="Update destination version scenario" airbyte_1=tt_airbyte_docker source_1=tt_postgres_source_aws_1 destination_1=tt_postgres_destination_aws_1 old_version="0.3.22" new_version="0.3.23"

❌ https://github.com/airbytehq/airbyte/actions/runs/3204372025

…vation * master: (32 commits) fixed octavia position and z-index on onboarding page (#17708) Revert "Revert "Do not wait the end of a reset to return an update (#17591)" (#17640)" (#17669) source-google-analytics-v4: use hits metric for check (#17717) Source linkedin-ads: retry 429/5xx when refreshing access token (#17724) 🐛 Source Mixpanel: solve cursor field none expected array (#17699) 🎉 8890 Source MySql: Fix large table issue by fetch size (#17236) Test e2e testing tool commands (#17722) fixed escape character i18n error (#17706) Docs: adds missing " in transformations-with-airbyte.md (#17723) Change Osano token to new project (#17720) Source Github: improve 502 handling for `comments` stream (#17715) #17506 source snapchat marketing: retry failed request for refreshing access token (#17596) MongoDb Source: Increase performance of discover (#17614) Testing tool commands for run scenarios (#17550) Kustomize: Missing NORMALIZATION_JOB_* environment variables in stable-with-resource-limits overlays (#17713) Fix console errors (#17696) Revert: #17047 Airbyte CDK: Improve error for returning non-iterable from connectors parse_response (#17707) #17047 Airbyte CDK: Improve error for returning non-iterable from connectors parse_response (#17626) 📝 Postgres source: document occasional full refresh under cdc mode (#17705) Bump Airbyte version from 0.40.12 to 0.40.13 (#17682) ...

* test pull request for testing testing-tool commands * test pull request for testing testing-tool commands * add command for run testing tool in main repo * small changes for test e2e testing tool commands * small changes for test e2e testing tool commands

andriikorotkov added 6 commits October 4, 2022 11:54

test pull request for testing testing-tool commands

46de753

Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…

75c9b21

…test_testing_tool_command � Conflicts: � .github/workflows/help-full-command.yml

test pull request for testing testing-tool commands

b703073

add command for run testing tool in main repo

3738d6c

Merge branch 'master' of github.com:airbytehq/airbyte into akorotkov/…

f1ad4f7

…test_testing_tool_command

small changes for test e2e testing tool commands

4f1e46b

andriikorotkov temporarily deployed to more-secrets October 7, 2022 11:12 Inactive

small changes for test e2e testing tool commands

38ab94d

andriikorotkov requested a review from alexandr-shegeda October 7, 2022 13:16

andriikorotkov marked this pull request as ready for review October 7, 2022 13:16

Merge branch 'master' into akorotkov/test_testing_tool_command

e9ed9c3

alexandr-shegeda approved these changes Oct 7, 2022

View reviewed changes

andriikorotkov merged commit 371da13 into master Oct 7, 2022

andriikorotkov deleted the akorotkov/test_testing_tool_command branch October 7, 2022 13:18

andriikorotkov temporarily deployed to more-secrets October 7, 2022 13:19 Inactive

octavia-squidington-iii mentioned this pull request Oct 7, 2022

Bump Airbyte version from 0.40.13 to 0.40.14 #17762

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test e2e testing tool commands #17722

Test e2e testing tool commands #17722

andriikorotkov commented Oct 7, 2022

andriikorotkov commented Oct 7, 2022 •

edited by github-actions bot

Loading

andriikorotkov commented Oct 7, 2022 •

edited by github-actions bot

Loading

andriikorotkov commented Oct 7, 2022 •

edited by github-actions bot

Loading

andriikorotkov commented Oct 7, 2022 •

edited by github-actions bot

Loading

andriikorotkov commented Oct 7, 2022 •

edited by github-actions bot

Loading

andriikorotkov commented Oct 7, 2022 •

edited by github-actions bot

Loading

Test e2e testing tool commands #17722

Test e2e testing tool commands #17722

Conversation

andriikorotkov commented Oct 7, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

andriikorotkov commented Oct 7, 2022 • edited by github-actions bot Loading

Scenario Update destination version scenario. ✔️

Call examples :

Instances in the scenario

Parameters in the scenario

Scenario actions

Preparation actions :

Scenario actions :

andriikorotkov commented Oct 7, 2022 • edited by github-actions bot Loading

Scenario Test invalid scenario. ❌

⚠️ Failed validations :

Call examples :

Instances in the scenario

Parameters in the scenario

andriikorotkov commented Oct 7, 2022 • edited by github-actions bot Loading

Call help examples :

Scenario validation sings :

Available scenarios :

andriikorotkov commented Oct 7, 2022 • edited by github-actions bot Loading

andriikorotkov commented Oct 7, 2022 • edited by github-actions bot Loading

andriikorotkov commented Oct 7, 2022 • edited by github-actions bot Loading

andriikorotkov commented Oct 7, 2022 •

edited by github-actions bot

Loading

Scenario `Update destination version scenario`. ✔️

andriikorotkov commented Oct 7, 2022 •

edited by github-actions bot

Loading

Scenario `Test invalid scenario`. ❌

andriikorotkov commented Oct 7, 2022 •

edited by github-actions bot

Loading

andriikorotkov commented Oct 7, 2022 •

edited by github-actions bot

Loading

andriikorotkov commented Oct 7, 2022 •

edited by github-actions bot

Loading

andriikorotkov commented Oct 7, 2022 •

edited by github-actions bot

Loading