bumping jsonschemafriend to 0.12.4 #37581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Apr 25, 2024
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @stephane-airbyte and the rest of your teammates on |
2 tasks
stephane-airbyte
changed the base branch from
stephane/04-24-remove_unnecessary_calls_to_tolist_
to
master
stephane-airbyte
force-pushed
the
stephane/04-25-bumping_jsonschemafriend_to_0.12.4
branch
from
0c4118f to
a366772
Compare
octavia-squidington-iii
added
the
area/documentation
benmoriceau
approved these changes
Apr 25, 2024
stephane-airbyte
deleted the
stephane/04-25-bumping_jsonschemafriend_to_0.12.4
branch
postamar
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsonschema seems to have moved from a javascript redirect to a HTTP redirect for their DRAFT_4 URL. Unfortunately, jsonschemafriend doesn't handle HTTP redirect in 0.12.1, which causes our 2e2 source to dump inordinate amounts of logs. This fixes it.
The test GeneratorTest was failing prior to this change and is now passing
I believe this is the PR that fixes the issue (having an offline version of the supported stores, so there's no dependency on the internet at all)