-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove nullable from generics #37555
Merged
stephane-airbyte
merged 1 commit into
master
from
stephane/04-24-remove_nullable_from_generics
May 23, 2024
Merged
remove nullable from generics #37555
stephane-airbyte
merged 1 commit into
master
from
stephane/04-24-remove_nullable_from_generics
May 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git βοΈ 1 Ignored Deployment
|
This was referenced Apr 24, 2024
This was referenced Apr 24, 2024
stephane-airbyte
force-pushed
the
stephane/04-24-remove_unnecessary_calls_to_tolist_
branch
from
April 24, 2024 22:44
5d1b68b
to
b3fd99e
Compare
stephane-airbyte
force-pushed
the
stephane/04-24-remove_nullable_from_generics
branch
from
April 24, 2024 22:44
5ed5a0a
to
e61b85a
Compare
stephane-airbyte
force-pushed
the
stephane/04-24-remove_unnecessary_calls_to_tolist_
branch
from
April 25, 2024 00:13
b3fd99e
to
2b8f4bb
Compare
stephane-airbyte
force-pushed
the
stephane/04-24-remove_nullable_from_generics
branch
from
April 25, 2024 00:13
e61b85a
to
bdb656b
Compare
stephane-airbyte
force-pushed
the
stephane/04-24-remove_unnecessary_calls_to_tolist_
branch
from
April 25, 2024 01:20
2b8f4bb
to
e92ae48
Compare
stephane-airbyte
force-pushed
the
stephane/04-24-remove_nullable_from_generics
branch
2 times, most recently
from
April 25, 2024 14:58
da670de
to
b78c13e
Compare
stephane-airbyte
force-pushed
the
stephane/04-24-remove_unnecessary_calls_to_tolist_
branch
from
May 22, 2024 18:53
e92ae48
to
a49d264
Compare
stephane-airbyte
force-pushed
the
stephane/04-24-remove_nullable_from_generics
branch
from
May 22, 2024 18:53
b78c13e
to
ae9e306
Compare
stephane-airbyte
force-pushed
the
stephane/04-24-remove_unnecessary_calls_to_tolist_
branch
from
May 22, 2024 19:53
a49d264
to
1921820
Compare
stephane-airbyte
force-pushed
the
stephane/04-24-remove_nullable_from_generics
branch
from
May 22, 2024 19:53
ae9e306
to
ced5117
Compare
stephane-airbyte
force-pushed
the
stephane/04-24-remove_unnecessary_calls_to_tolist_
branch
from
May 22, 2024 20:12
1921820
to
33f3a50
Compare
stephane-airbyte
force-pushed
the
stephane/04-24-remove_nullable_from_generics
branch
from
May 22, 2024 20:12
ced5117
to
d002a2d
Compare
stephane-airbyte
force-pushed
the
stephane/04-24-remove_unnecessary_calls_to_tolist_
branch
from
May 22, 2024 20:56
33f3a50
to
2fd07b2
Compare
stephane-airbyte
force-pushed
the
stephane/04-24-remove_nullable_from_generics
branch
from
May 22, 2024 20:56
d002a2d
to
b203d86
Compare
stephane-airbyte
force-pushed
the
stephane/04-24-remove_unnecessary_calls_to_tolist_
branch
from
May 22, 2024 21:45
2fd07b2
to
2dfe157
Compare
stephane-airbyte
force-pushed
the
stephane/04-24-remove_nullable_from_generics
branch
from
May 22, 2024 21:45
b203d86
to
a4961f5
Compare
2 tasks
stephane-airbyte
force-pushed
the
stephane/04-24-remove_unnecessary_calls_to_tolist_
branch
from
May 22, 2024 22:35
2dfe157
to
a9ae0e8
Compare
stephane-airbyte
force-pushed
the
stephane/04-24-remove_nullable_from_generics
branch
from
May 22, 2024 22:35
a4961f5
to
9f4d61b
Compare
2 tasks
stephane-airbyte
force-pushed
the
stephane/04-24-remove_nullable_from_generics
branch
from
May 22, 2024 22:51
9f4d61b
to
caca8fd
Compare
stephane-airbyte
force-pushed
the
stephane/04-24-remove_unnecessary_calls_to_tolist_
branch
from
May 22, 2024 23:10
5d48aec
to
e6ef20e
Compare
stephane-airbyte
force-pushed
the
stephane/04-24-remove_nullable_from_generics
branch
from
May 22, 2024 23:10
caca8fd
to
939aa70
Compare
stephane-airbyte
force-pushed
the
stephane/04-24-remove_unnecessary_calls_to_tolist_
branch
from
May 22, 2024 23:45
e6ef20e
to
1a21a77
Compare
stephane-airbyte
force-pushed
the
stephane/04-24-remove_nullable_from_generics
branch
from
May 22, 2024 23:45
939aa70
to
57b123e
Compare
stephane-airbyte
force-pushed
the
stephane/04-24-remove_unnecessary_calls_to_tolist_
branch
from
May 23, 2024 00:25
1a21a77
to
57615ce
Compare
stephane-airbyte
force-pushed
the
stephane/04-24-remove_nullable_from_generics
branch
from
May 23, 2024 00:25
57b123e
to
e7d7e90
Compare
stephane-airbyte
force-pushed
the
stephane/04-24-remove_unnecessary_calls_to_tolist_
branch
from
May 23, 2024 03:53
57615ce
to
b126b06
Compare
stephane-airbyte
force-pushed
the
stephane/04-24-remove_nullable_from_generics
branch
from
May 23, 2024 03:53
e7d7e90
to
41e795c
Compare
stephane-airbyte
requested review from
a team,
akashkulk,
edgao,
gisripa,
postamar and
rodireich
May 23, 2024 05:34
stephane-airbyte
force-pushed
the
stephane/04-24-remove_unnecessary_calls_to_tolist_
branch
from
May 23, 2024 14:22
b126b06
to
a7b52c0
Compare
stephane-airbyte
force-pushed
the
stephane/04-24-remove_nullable_from_generics
branch
2 times, most recently
from
May 23, 2024 14:27
936be01
to
9167bae
Compare
edgao
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rubberstamping
gisripa
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats a lot of useless nullable things π
Merge activity
|
stephane-airbyte
changed the base branch from
stephane/04-24-remove_unnecessary_calls_to_tolist_
to
graphite-base/37555
May 23, 2024 18:22
stephane-airbyte
force-pushed
the
stephane/04-24-remove_nullable_from_generics
branch
from
May 23, 2024 18:38
9167bae
to
5c65df2
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?