Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace all java collectors.toSet with kotlin construct #37538

Merged
merged 1 commit into from
May 23, 2024
Merged

replace all java collectors.toSet with kotlin construct #37538

merged 1 commit into from
May 23, 2024

Conversation

stephane-airbyte
Copy link
Contributor

What

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@stephane-airbyte Graphite App
Copy link
Contributor Author

stephane-airbyte commented Apr 24, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

This was referenced Apr 24, 2024
Merged
Merged
@vercel Vercel
Copy link

vercel bot commented Apr 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 23, 2024 6:04pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Apr 24, 2024
This was referenced Apr 24, 2024
Merged
Merged
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.tolist_with_kotlin_construct branch from 1b6c2f1 to e7b0a93 Compare April 24, 2024 15:08
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.toset_with_kotlin_construct branch from e9c6e0b to 8e1fa10 Compare April 24, 2024 15:08
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.tolist_with_kotlin_construct branch from e7b0a93 to 6d44ded Compare April 24, 2024 16:21
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.toset_with_kotlin_construct branch from 8e1fa10 to 94b3f5f Compare April 24, 2024 16:21
@stephane-airbyte stephane-airbyte mentioned this pull request Apr 24, 2024
Merged
2 tasks
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.tolist_with_kotlin_construct branch from 6d44ded to 9a6ddf1 Compare April 25, 2024 00:13
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.toset_with_kotlin_construct branch from 94b3f5f to f4993cd Compare April 25, 2024 00:13
@stephane-airbyte stephane-airbyte mentioned this pull request Apr 25, 2024
Merged
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.tolist_with_kotlin_construct branch from 9a6ddf1 to 34b8e6b Compare May 22, 2024 18:53
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.toset_with_kotlin_construct branch from f4993cd to 40ec450 Compare May 22, 2024 18:53
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.tolist_with_kotlin_construct branch from 34b8e6b to abcd37c Compare May 22, 2024 19:52
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.toset_with_kotlin_construct branch from 40ec450 to dff0e27 Compare May 22, 2024 19:52
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.tolist_with_kotlin_construct branch from abcd37c to 8346939 Compare May 22, 2024 20:12
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.toset_with_kotlin_construct branch from dff0e27 to f511458 Compare May 22, 2024 20:12
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.tolist_with_kotlin_construct branch from 8346939 to 58a3fb0 Compare May 22, 2024 20:56
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.toset_with_kotlin_construct branch from f511458 to bc2e1f5 Compare May 22, 2024 20:56
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.tolist_with_kotlin_construct branch from 58a3fb0 to ff32b39 Compare May 22, 2024 21:45
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.toset_with_kotlin_construct branch from bc2e1f5 to e9bd2b1 Compare May 22, 2024 21:45
@stephane-airbyte stephane-airbyte mentioned this pull request May 22, 2024
Merged
2 tasks
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.tolist_with_kotlin_construct branch from ff32b39 to de84e79 Compare May 22, 2024 22:35
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.toset_with_kotlin_construct branch from e9bd2b1 to b3838ee Compare May 22, 2024 22:35
@stephane-airbyte stephane-airbyte mentioned this pull request May 22, 2024
Merged
2 tasks
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.tolist_with_kotlin_construct branch from de84e79 to b8397c6 Compare May 22, 2024 22:51
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.toset_with_kotlin_construct branch from b3838ee to 2ba1799 Compare May 22, 2024 22:51
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.tolist_with_kotlin_construct branch from b8397c6 to 610061c Compare May 22, 2024 23:10
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.toset_with_kotlin_construct branch 2 times, most recently from e80c347 to c870a2c Compare May 22, 2024 23:45
@stephane-airbyte stephane-airbyte marked this pull request as ready for review May 23, 2024 05:34
@stephane-airbyte stephane-airbyte requested review from a team, akashkulk, edgao, gisripa, postamar and rodireich and removed request for a team May 23, 2024 05:34
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.tolist_with_kotlin_construct branch from 610061c to ea6f22e Compare May 23, 2024 14:21
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.toset_with_kotlin_construct branch from c870a2c to 06355c7 Compare May 23, 2024 14:21
gisripa
gisripa reviewed May 23, 2024
View reviewed changes
...urces/src/main/kotlin/io/airbyte/cdk/integrations/source/relationaldb/state/CursorManager.kt
@@ -103,7 +102,7 @@ class CursorManager<S : Any>(
.map { stream: AirbyteStream ->
AirbyteStreamNameNamespacePair.fromAirbyteStream(stream)
}
.collect(Collectors.toSet())
.toMutableSet()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this specific one is a mutable set ? did some test catch that it needs to be mutated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the line below does an addAll

@stephane-airbyte Graphite App
Copy link
Contributor Author

stephane-airbyte commented May 23, 2024 •
edited
Loading

Merge activity

@stephane-airbyte stephane-airbyte changed the base branch from stephane/04-23-replace_all_java_collectors.tolist_with_kotlin_construct to graphite-base/37538 May 23, 2024 17:55
@stephane-airbyte stephane-airbyte changed the base branch from graphite-base/37538 to master May 23, 2024 18:02
@stephane-airbyte stephane-airbyte force-pushed the stephane/04-23-replace_all_java_collectors.toset_with_kotlin_construct branch from 06355c7 to 6a0211a Compare May 23, 2024 18:03
@stephane-airbyte stephane-airbyte merged commit 0805f9e into master May 23, 2024
27 checks passed
@stephane-airbyte stephane-airbyte deleted the stephane/04-23-replace_all_java_collectors.toset_with_kotlin_construct branch May 23, 2024 18:09
@stephane-airbyte stephane-airbyte mentioned this pull request May 23, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgao edgao edgao approved these changes

@gisripa gisripa gisripa approved these changes

@akashkulk akashkulk Awaiting requested review from akashkulk

@postamar postamar Awaiting requested review from postamar

@rodireich rodireich Awaiting requested review from rodireich

Assignees
No one assigned
Labels
CDK Connector Development Kit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephane-airbyte @gisripa @edgao @octavia-squidington-iii