remove log4j from java cdk #38583
Merged
remove log4j from java cdk #38583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This was referenced May 22, 2024
stephane-airbyte
force-pushed
the
stephane/04-24-remove_nullable_from_generics
branch
from
a4961f5 to
9f4d61b
Compare
stephane-airbyte
force-pushed
the
stephane/04-26-remove_log4j_from_java_cdk
branch
from
36275d1 to
1559372
Compare
2 tasks
stephane-airbyte
force-pushed
the
stephane/04-24-remove_nullable_from_generics
branch
from
9f4d61b to
caca8fd
Compare
stephane-airbyte
force-pushed
the
stephane/04-26-remove_log4j_from_java_cdk
branch
from
1559372 to
8f12f17
Compare
stephane-airbyte
force-pushed
the
stephane/04-24-remove_nullable_from_generics
branch
from
caca8fd to
939aa70
Compare
stephane-airbyte
force-pushed
the
stephane/04-26-remove_log4j_from_java_cdk
branch
from
8f12f17 to
b3a8afd
Compare
stephane-airbyte
force-pushed
the
stephane/04-24-remove_nullable_from_generics
branch
from
939aa70 to
57b123e
Compare
stephane-airbyte
force-pushed
the
stephane/04-26-remove_log4j_from_java_cdk
branch
from
b3a8afd to
fbca668
Compare
stephane-airbyte
force-pushed
the
stephane/04-24-remove_nullable_from_generics
branch
from
57b123e to
e7d7e90
Compare
stephane-airbyte
force-pushed
the
stephane/04-26-remove_log4j_from_java_cdk
branch
from
fbca668 to
78bd0c6
Compare
stephane-airbyte
force-pushed
the
stephane/04-24-remove_nullable_from_generics
branch
from
e7d7e90 to
41e795c
Compare
stephane-airbyte
force-pushed
the
stephane/04-26-remove_log4j_from_java_cdk
branch
2 times, most recently
from
e38c6ad to
22a3f6a
Compare
stephane-airbyte
requested review from
a team,
akashkulk,
edgao,
gisripa and
postamar
stephane-airbyte
force-pushed
the
stephane/04-24-remove_nullable_from_generics
branch
from
41e795c to
936be01
Compare
stephane-airbyte
force-pushed
the
stephane/04-26-remove_log4j_from_java_cdk
branch
from
22a3f6a to
5949ada
Compare
stephane-airbyte
force-pushed
the
stephane/04-24-remove_nullable_from_generics
branch
from
936be01 to
9167bae
Compare
stephane-airbyte
force-pushed
the
stephane/04-26-remove_log4j_from_java_cdk
branch
from
5949ada to
a163df0
Compare
edgao
approved these changes
May 23, 2024
| import org.slf4j.Logger | ||
| import org.slf4j.LoggerFactory | ||
|
|
||
| private val LOGGER = KotlinLogging.logger {} |
There was a problem hiding this comment.
curious: is it preferable to declare the logger outside the class?
There was a problem hiding this comment.
Yeah this is a question i have too. I'm inconsistently doing it inside the class and only outside when I need it in companion object.
There was a problem hiding this comment.
I think it's either outside the class or inside the companion object. Definitely not inside the class, as that would create a new instance for each class instance
| companion object { | ||
| private val LOGGER: Logger = LoggerFactory.getLogger(DefaultJdbcDatabase::class.java) | ||
| } | ||
| companion object {} |
stephane-airbyte
force-pushed
the
stephane/04-26-remove_log4j_from_java_cdk
branch
from
a163df0 to
5b48886
Compare
gisripa
approved these changes
May 23, 2024
Merge activity
|
stephane-airbyte
changed the base branch from
stephane/04-24-remove_nullable_from_generics
to
graphite-base/38583
stephane-airbyte
force-pushed
the
stephane/04-26-remove_log4j_from_java_cdk
branch
from
5b48886 to
4dbf965
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?