feat: remove sub-account support for light account #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avasisht23
requested review from
moldy530,
rthomare,
dancoombs,
mokok123 and
denniswon
as code owners
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
avasisht23
requested review from
adam-alchemy and
howydev
and removed request for
rthomare,
dancoombs and
mokok123
howydev
reviewed
Oct 30, 2023
This was referenced Oct 30, 2023
denniswon
approved these changes
Oct 31, 2023
avasisht23
force-pushed
the
10-30-feat_remove_sub-account_support_for_light_account
branch
from
75eae27 to
ab6a936
Compare
This was referenced Oct 31, 2023
avasisht23
deleted the
10-30-feat_remove_sub-account_support_for_light_account
branch
avasisht23
added a commit
that referenced
this pull request
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on updating the
argsparameter in thecreateAccountfunction inutils.tsto always use0nas the second argument, indicating that the light account does not support sub-accounts.Detailed summary
argsparameter increateAccountfunction to use[await this.owner.getAddress(), 0n]instead of[await this.owner.getAddress(), this.index]