-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add zod runtime validation for ethers adapter provider #188
Merged
avasisht23
merged 6 commits into
development
from
10-30-feat_add_zod_runtime_validation_for_ethers_adapter_provider
Nov 2, 2023
Merged
feat: add zod runtime validation for ethers adapter provider #188
avasisht23
merged 6 commits into
development
from
10-30-feat_add_zod_runtime_validation_for_ethers_adapter_provider
Nov 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avasisht23
requested review from
moldy530,
rthomare,
dancoombs,
mokok123 and
denniswon
as code owners
October 31, 2023 01:19
This was referenced Oct 31, 2023
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Oct 31, 2023
denniswon
suggested changes
Oct 31, 2023
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_alchemy_provider
branch
from
October 31, 2023 03:30
86c5518
to
b1584bc
Compare
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_ethers_adapter_provider
branch
from
October 31, 2023 03:30
5a88163
to
5c2280b
Compare
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_alchemy_provider
branch
from
November 1, 2023 15:37
b1584bc
to
e6c8f85
Compare
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_ethers_adapter_provider
branch
from
November 1, 2023 15:37
5c2280b
to
700d1b1
Compare
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_alchemy_provider
branch
from
November 1, 2023 17:03
e6c8f85
to
704518b
Compare
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_ethers_adapter_provider
branch
from
November 1, 2023 17:03
700d1b1
to
4249a75
Compare
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_alchemy_provider
branch
from
November 1, 2023 17:06
704518b
to
2d27ffb
Compare
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_ethers_adapter_provider
branch
from
November 1, 2023 17:06
4249a75
to
a26f1d8
Compare
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_alchemy_provider
branch
from
November 1, 2023 17:27
2d27ffb
to
e28fd37
Compare
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_ethers_adapter_provider
branch
from
November 1, 2023 17:27
b192f03
to
3fee977
Compare
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_alchemy_provider
branch
from
November 1, 2023 17:30
e28fd37
to
f9a2c25
Compare
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_ethers_adapter_provider
branch
from
November 1, 2023 17:30
3fee977
to
e67627f
Compare
Base automatically changed from
10-30-feat_add_zod_runtime_validation_for_alchemy_provider
to
development
November 2, 2023 02:32
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_ethers_adapter_provider
branch
2 times, most recently
from
November 2, 2023 17:56
04ce1b8
to
1abeafa
Compare
denniswon
suggested changes
Nov 2, 2023
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_ethers_adapter_provider
branch
from
November 2, 2023 19:32
1abeafa
to
64a582c
Compare
denniswon
approved these changes
Nov 2, 2023
avasisht23
deleted the
10-30-feat_add_zod_runtime_validation_for_ethers_adapter_provider
branch
November 2, 2023 19:57
avasisht23
added a commit
that referenced
this pull request
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test
)site
folder, see guidleines below)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:fix
)development
and notmain
?PR-Codex overview
Detailed summary
EthersProviderAdapterOptsSchema
schema definition intypes.ts
.EthersProviderAdapterOptsSchema
inprovider-adapter.ts
to validate the options passed toEthersProviderAdapter
constructor.provider-adapter.test.ts
to check runtime validation when theentryPoint
is invalid.