feat: add zod runtime validation for base account #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avasisht23
requested review from
moldy530,
rthomare,
dancoombs,
mokok123 and
denniswon
as code owners
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
denniswon
approved these changes
Oct 31, 2023
avasisht23
force-pushed
the
10-30-feat_remove_sub-account_support_for_light_account
branch
from
75eae27 to
ab6a936
Compare
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_base_account
branch
from
699ffa9 to
45938b6
Compare
This was referenced Oct 31, 2023
Base automatically changed from
10-30-feat_remove_sub-account_support_for_light_account
to
development
October 31, 2023 01:42
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_base_account
branch
from
45938b6 to
c9f6992
Compare
moldy530
reviewed
Oct 31, 2023
moldy530
reviewed
Oct 31, 2023
There was a problem hiding this comment.
can we break out these common refine functions into some kind of refinement util?
The chain and client ones especially are used in other places
or even provide them as the full schema: export const zThingSchem = z.any().refine<Thing>(() => ) then we just import them there
avasisht23
force-pushed
the
10-30-feat_add_zod_runtime_validation_for_base_account
branch
from
c9f6992 to
ded9808
Compare
moldy530
reviewed
Nov 1, 2023
moldy530
reviewed
Nov 1, 2023
moldy530
reviewed
Nov 1, 2023
moldy530
approved these changes
Nov 1, 2023
moldy530
deleted the
10-30-feat_add_zod_runtime_validation_for_base_account
branch
avasisht23
added a commit
that referenced
this pull request
Nov 3, 2023
* feat: add zod runtime validation for base account * feat: add zod runtime validation for base account * feat: add zod runtime validation for simple account * refactor: clean up base schemas * refactor: rebase * refactor: rename abitype import
avasisht23
added a commit
that referenced
this pull request
Nov 3, 2023
* feat: add zod runtime validation for base account * feat: add zod runtime validation for base account * feat: add zod runtime validation for simple account * refactor: clean up base schemas * refactor: rebase * refactor: rename abitype import
Merged
moldy530
pushed a commit
that referenced
this pull request
Nov 10, 2023
* feat: add zod runtime validation for base account * feat: add zod runtime validation for base account * feat: add zod runtime validation for simple account * refactor: clean up base schemas * refactor: rebase * refactor: rename abitype import
avasisht23
added a commit
that referenced
this pull request
Nov 14, 2023
* feat: add zod runtime validation for base account * feat: add zod runtime validation for base account * feat: add zod runtime validation for simple account * refactor: clean up base schemas * refactor: rebase * refactor: rename abitype import
avasisht23
added a commit
that referenced
this pull request
Nov 14, 2023
* feat: add zod runtime validation for base account * feat: add zod runtime validation for base account * feat: add zod runtime validation for simple account * refactor: clean up base schemas * refactor: rebase * refactor: rename abitype import
denniswon
pushed a commit
that referenced
this pull request
Nov 16, 2023
* feat: add zod runtime validation for base account * feat: add zod runtime validation for base account * feat: add zod runtime validation for simple account * refactor: clean up base schemas * refactor: rebase * refactor: rename abitype import
moldy530
pushed a commit
that referenced
this pull request
Nov 16, 2023
* feat: add zod runtime validation for base account * feat: add zod runtime validation for base account * feat: add zod runtime validation for simple account * refactor: clean up base schemas * refactor: rebase * refactor: rename abitype import
avasisht23
added a commit
that referenced
this pull request
Dec 3, 2023
* feat: add zod runtime validation for base account * feat: add zod runtime validation for base account * feat: add zod runtime validation for simple account * refactor: clean up base schemas * refactor: rebase * refactor: rename abitype import
avasisht23
added a commit
that referenced
this pull request
Dec 3, 2023
* feat: add zod runtime validation for base account * feat: add zod runtime validation for base account * feat: add zod runtime validation for simple account * refactor: clean up base schemas * refactor: rebase * refactor: rename abitype import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add zod runtime validation for base account.
PR-Codex overview
This PR focuses on adding new schemas and types for smart account providers and accounts.
Detailed summary:
SignerSchemafor validating smart account signers.ChainSchemafor validating chain objects.createPublicErc4337ClientSchemafor validating public ERC4337 clients.createSmartAccountProviderConfigSchemato use the new schemas and types.createBaseSmartAccountParamsSchemato use the new schemas and types.