Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds unit testing relevance methods #777

Merged
merged 7 commits into from
Sep 25, 2019
Merged

feat: adds unit testing relevance methods #777

merged 7 commits into from
Sep 25, 2019

Conversation

nunomaduro
Copy link

This pull request adds findObject and getObjectPosition as specified on the api client specs.

addresses #771

@Haroenv
Copy link
Contributor

Haroenv commented Sep 3, 2019

Cool! Looks like these are added to lite while they shouldn’t

@nunomaduro
Copy link
Author

Humm, I have added a new error into the errors.js. That may be the issue. Correct?

chloelbn
chloelbn suggested changes Sep 4, 2019
View reviewed changes
src/Index.js Outdated Show resolved Hide resolved
@nunomaduro
feat(unit-testing-relevance): fixes query param on request-options
09feb0e 
Co-Authored-By: Chloe Liban <chloe.liban@frichti.co>
@nunomaduro nunomaduro requested a review from chloelbn September 4, 2019 10:52
chloelbn
chloelbn previously approved these changes Sep 4, 2019
View reviewed changes
Copy link

@chloelbn chloelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@nunomaduro nunomaduro mentioned this pull request Sep 4, 2019
Merged
@nunomaduro
Copy link
Author

Waiting for #779.

Haroenv
Haroenv reviewed Sep 9, 2019
View reviewed changes
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good :)

src/Index.js Show resolved Hide resolved
src/Index.js Show resolved Hide resolved
src/Index.js Outdated Show resolved Hide resolved
Haroenv
Haroenv previously approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test failure is unrelated flakiness, code looks good to me

src/Index.js Outdated Show resolved Hide resolved
@nunomaduro @Haroenv
feat(unit-testing-relevance): typo on docs
8fdc742 
Co-Authored-By: Haroen Viaene <hello@haroen.me>
@nunomaduro nunomaduro merged commit 5f7fb6c into develop Sep 25, 2019
@nunomaduro nunomaduro deleted the feat/unit-testing-relevance branch September 25, 2019 12:59
@nunomaduro
Copy link
Author

Tests are not passing on this specific branch. And as discussed with @Haroenv - we are going to launch the CI on the develop.

nunomaduro added a commit that referenced this pull request Sep 26, 2019
@nunomaduro
3.35.0
cff5f96 
* FEAT(remaining-validity): adds remaining valitity method (#778)
* FEAT(unit-testing-relevance): adds unit testing relevance methods (#777)
* FEAT(adds-assign-user-ids): adds assignUserIDs method and tests (#783)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haroenv Haroenv Haroenv left review comments

@chloelbn chloelbn chloelbn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nunomaduro @Haroenv @chloelbn