Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds assign user ids method #783

Merged
merged 2 commits into from
Sep 26, 2019
Merged

feat: adds assign user ids method #783

merged 2 commits into from
Sep 26, 2019

Conversation

nunomaduro
Copy link

@nunomaduro nunomaduro commented Sep 25, 2019 •
edited by Haroenv
Loading

This pull request adds the assignUserIds method as specified in our internal specs: TODO.

fixes #784

@nunomaduro nunomaduro self-assigned this Sep 25, 2019
Haroenv
Haroenv approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this will work!

src/AlgoliaSearch.js Show resolved Hide resolved
@nunomaduro nunomaduro merged commit 9ae3ced into develop Sep 26, 2019
@nunomaduro
Copy link
Author

Tests were passing, just before we merged develop on this one. Merging this, and fixing thing on the develop branch after.

@nunomaduro nunomaduro deleted the feat/adds-assign-user-ids branch September 26, 2019 08:18
nunomaduro added a commit that referenced this pull request Sep 26, 2019
@nunomaduro
3.35.0
cff5f96 
* FEAT(remaining-validity): adds remaining valitity method (#778)
* FEAT(unit-testing-relevance): adds unit testing relevance methods (#777)
* FEAT(adds-assign-user-ids): adds assignUserIDs method and tests (#783)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haroenv Haroenv Haroenv approved these changes

@chloelbn chloelbn Awaiting requested review from chloelbn

Assignees

@nunomaduro nunomaduro

Labels
DO NOT MERGE YET enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add method assignUserIDs
2 participants
@nunomaduro @Haroenv