Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remaining-validity #778

Merged
merged 2 commits into from
Sep 4, 2019
Merged

feat: remaining-validity #778

merged 2 commits into from
Sep 4, 2019

Conversation

nunomaduro
Copy link

This pull request adds getSecuredApiKeyRemainingValidity as specified on the api client specs.

closes #772

@nunomaduro nunomaduro self-assigned this Sep 4, 2019
@Haroenv
Copy link
Contributor

Haroenv commented Sep 4, 2019

Looks good, bundle size change is odd though, since angular shouldn’t have this file, maybe it’s just the error

chloelbn
chloelbn approved these changes Sep 4, 2019
View reviewed changes
Copy link

@chloelbn chloelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't have any idea about the bundle size either tho

@nunomaduro nunomaduro mentioned this pull request Sep 4, 2019
Merged
@nunomaduro
Copy link
Author

Waiting for #779.

@nunomaduro nunomaduro merged commit 536f4a6 into develop Sep 4, 2019
@nunomaduro nunomaduro deleted the feat/remaining-validity branch September 4, 2019 15:33
nunomaduro added a commit that referenced this pull request Sep 26, 2019
@nunomaduro
3.35.0
cff5f96 
* FEAT(remaining-validity): adds remaining valitity method (#778)
* FEAT(unit-testing-relevance): adds unit testing relevance methods (#777)
* FEAT(adds-assign-user-ids): adds assignUserIDs method and tests (#783)
@julienbourdeau
Copy link

It seems like this is only implemented for Node, not in the browser, am I correct?

If so, why is it not available in the browser?

@nunomaduro
Copy link
Author

nunomaduro commented Nov 6, 2019 •
edited
Loading

Because the generateSecuredApiKey as also browser only. On the JavaScript v4 on the default preset will contain this features on the browser too.

@julienbourdeau
Copy link

I understand 👍 I'm very exited for v4.
This is a very important feature, as your frontend might be using secured api key, you need to know when to ask for a new key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chloelbn chloelbn chloelbn approved these changes

@Haroenv Haroenv Awaiting requested review from Haroenv

Assignees

@nunomaduro nunomaduro

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New method: GetSecuredApiKeyRemainingValidity
4 participants
@nunomaduro @Haroenv @julienbourdeau @chloelbn