Release 2.2.0crp #102
Merged
Release 2.2.0crp #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Link to new Module Repo
- use: std::vector<HeapInfo> mallocMC::getHeapLocations() - uses a vector, since future allocators might have more than 1 heap (and those are not necessarily located one after another) - currently, HeapInfo contains size and a pointer p - the pointer is the device address (as it would be returned my cudaMalloc for example) - the CUDA toolkit allocator will currently return NULL. Ideas very welcome. Problem: we have no pointer address for its internal heap (might be multiple heaps, who knows). Also, we don't know how objects are organized on the heap, so copying to host might be of limited value anyway.
- add typedef for `vector<HeapInfo>` in `mallocMC_hostclass` - add missing includes `<vector>`
fix broken compile
added host function to return heap pointer
fix non-matching class/struct declaration
Currently the `getAvailableSlotsHost` function of a `CreationPolicy` is required irrespective of its availability. In the [source](https://github.com/ComputationalRadiationPhysics/mallocMC/blob/84c8c20309633c98f69be83153eb897ce2d83110/src/include/mallocMC/mallocMC_hostclass.hpp#L144-155) the `CreationPolicy::providesAvailableSlots::value` flag is checked in a runtime `if` so the function is required for all CreationPolicies even for `OldMalloc`. This has been changed to a compile time construct.
differenciate -> differentiate
fix a spelling mistake
__THROW is defined in Glibc so it is not available on all platforms. The safest way to fix this is to define it empty for platforms where it is not available. Maybe it is also safe to remove it completely.
fix unconditional usage of getAvailableSlotsHost
Define __THROW for systems without Glibc
Require CMake 2.8.12.2+ for the whole project to ensure the full build chain until a project that is using the FindmallocMC.cmake module will pass. Dependency increase in ComputationalRadiationPhysics/cmake-modules#8
Close #92: Update CMake Version to 2.8.12.2+
GCC: - Wshadow - Werror (used in compile suite) ICC: - Wshadow
Wshadow Compliance
- Since the warning (and the cast necessary to suppress it) are solved in newer versions of nvcc/gcc, one bright day in the future might permit us to remove that dreadful cast again.
Added TODO to boost_static_assert cast warning
- replaced by `uint32_t` from `<boost/cstdint.hpp>`
removed typedef uint32_richtig_huebsch
Prepare version 2.2.0crp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.