Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge devel in main #1

Merged
merged 39 commits into from
Jun 8, 2021
Merged

Merge devel in main #1

merged 39 commits into from
Jun 8, 2021

Conversation

Giulero
Copy link
Collaborator

@Giulero Giulero commented May 27, 2021

This PR implements a first draft of the library.
For now, I implemented:

  • Center of Mass position
  • Jacobians
  • Forward kinematics
  • Mass Matrix via CRBA
  • Centroidal Momentum Matrix via CRBA

@traversaro I add just you as a reviewer since the list is restricted to just 4 people.

@Giulero Giulero self-assigned this May 27, 2021
@Giulero Giulero requested review from traversaro and removed request for traversaro May 27, 2021 15:29
@Giulero Giulero marked this pull request as ready for review May 27, 2021 15:32
@Giulero Giulero changed the title Devel Merge devel in main May 27, 2021
Add github action
@Giulero Giulero requested a review from GiulioRomualdi May 27, 2021 20:23
.github/workflows/tests.yml Outdated Show resolved Hide resolved
adam/Computations/KinDynComputations.py Outdated Show resolved Hide resolved
adam/Computations/KinDynComputations.py Outdated Show resolved Hide resolved
adam/Computations/KinDynComputations.py Outdated Show resolved Hide resolved
adam/Computations/KinDynComputations.py Outdated Show resolved Hide resolved
adam/Geometry/utils.py Outdated Show resolved Hide resolved
urdf/iCubGenova04/model.urdf Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
tests/test_computations.py Outdated Show resolved Hide resolved
tests/test_computations.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
adam/__init__.py Outdated Show resolved Hide resolved
.github/workflows/tests.yml Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
adam/Computations/KinDynComputations.py Outdated Show resolved Hide resolved
Copy link
Contributor

@traversaro traversaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only pending comment from my side is #1 (comment), but it is not blocking and we can solve it later.

Copy link
Member

@diegoferigo diegoferigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, this PR is much more 🐍 now. I've left some last comments.

setup.cfg Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
adam/core/computations.py Outdated Show resolved Hide resolved
adam/core/computations.py Outdated Show resolved Hide resolved
adam/core/computations.py Outdated Show resolved Hide resolved
@Giulero
Copy link
Collaborator Author

Giulero commented Jun 8, 2021

Thanks guys! I really learned a lot :)

@Giulero Giulero merged commit ac676a3 into main Jun 8, 2021
@Giulero Giulero deleted the devel branch June 8, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants