Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong parameter type in centroidal MPC documentation #694

Open
CarlottaSartore opened this issue Jun 28, 2023 · 1 comment
Open

Wrong parameter type in centroidal MPC documentation #694

CarlottaSartore opened this issue Jun 28, 2023 · 1 comment

Comments

@CarlottaSartore
Copy link
Contributor

The documentation for the centroidal mpc parameter has some issues (at least if one want to set the parameter via code rather than via conf file):

* | `sampling_time` | `double` | Sampling time of the MPC. | Yes |
* | `time_horizon` | `double` | The time horizon of the MPC. The number of knots will be given by `floor(time_horizon / sampling_time)` | Yes |

the time_horizon and sampling_time variable are datetime rather than double.

In addition, the unit is missing (I assume they are seconds).

@GiulioRomualdi if you want (and agree) I can fix them either in #650 or open a new PR ! Let me know

@GiulioRomualdi
Copy link
Member

You can open a PR! Thank you 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants