Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python bindings for : Centroidal MPC, Centroidal Dynamics and Contacts #650

Merged

Conversation

CarlottaSartore
Copy link
Contributor

Still working on the implementation of the tests

@GiulioRomualdi
Copy link
Member

Hi @CarlottaSartore #645 got merged so you can rebase the PR on top of master :)

@CarlottaSartore
Copy link
Contributor Author

CarlottaSartore commented Jun 28, 2023

Adding the bindings for the Centroidal dynamics creates issues, when I try to import blf in my framework I got the following error:

In [1]: import bipedal_locomotion_framework as blf
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
Cell In[1], line 1
----> 1 import bipedal_locomotion_framework as blf

File ~/iit_ws/prepare_pr/bipedal-locomotion-framework/build/bipedal_locomotion_framework/__init__.py:2
      1 from .bindings import *
----> 2 from . import utils

ImportError: cannot import name 'utils' from partially initialized module 'bipedal_locomotion_framework' (most likely due to a circular import) (/home/carlotta/iit_ws/prepare_pr/bipedal-locomotion-framework/build/bipedal_locomotion_framework/__init__.py)

Introduced with commit

commit eabd35fd7c26874efbce62b8aa52f847260e1772 (HEAD -> python_bindings/centroidal_mpc, CarlottaFork/python_bindings/centroidal_mpc)
Author: Carlotta <carlotta.sartore@iit.it>
Date:   Wed Jun 28 15:42:03 2023 +0200

    added centroidal dynamic bindings

Sincerely I am having a hard time understanding which is the issue, in the implementation prior to the rebase, everything was working fine

@GiulioRomualdi
Copy link
Member

In which folder are you loading the bindings? If you do it in the build folder is not working

@CarlottaSartore CarlottaSartore changed the title Python bindings for centroidal MPC (Test missing) Python bindings for : Centrodal MPC, Centroidal Dynamics and Contacts Jun 30, 2023
@CarlottaSartore CarlottaSartore marked this pull request as ready for review June 30, 2023 14:01
@CarlottaSartore
Copy link
Contributor Author

Thanks @GiulioRomualdi !
I should have finalize all,this PR contains:

  • Python Bindings for the Centroidal MPC
  • Python Bindings for the Centroidal Dynamics
  • Python Bindings for the Contacts;

I have also added the tests and all seems to pass.

(Side Note: Loading the bindings not in the build directory solved the issue)

@GiulioRomualdi GiulioRomualdi changed the title Python bindings for : Centrodal MPC, Centroidal Dynamics and Contacts Python bindings for : Centroidal MPC, Centroidal Dynamics and Contacts Jun 30, 2023
@GiulioRomualdi
Copy link
Member

Thank you @CarlottaSartore for the effort I will merge it as soon as the CI ends. Thank you for the effort this will be really useful for @LoreMoretti and @paolo-viceconte

@GiulioRomualdi GiulioRomualdi merged commit 86e4e57 into ami-iit:master Jun 30, 2023
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants