-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python bindings for : Centroidal MPC, Centroidal Dynamics and Contacts #650
Python bindings for : Centroidal MPC, Centroidal Dynamics and Contacts #650
Conversation
Hi @CarlottaSartore #645 got merged so you can rebase the PR on top of master :) |
…neration in MPC y
9faa3bf
to
a8d6a8c
Compare
Adding the bindings for the Centroidal dynamics creates issues, when I try to import blf in my framework I got the following error: In [1]: import bipedal_locomotion_framework as blf
---------------------------------------------------------------------------
ImportError Traceback (most recent call last)
Cell In[1], line 1
----> 1 import bipedal_locomotion_framework as blf
File ~/iit_ws/prepare_pr/bipedal-locomotion-framework/build/bipedal_locomotion_framework/__init__.py:2
1 from .bindings import *
----> 2 from . import utils
ImportError: cannot import name 'utils' from partially initialized module 'bipedal_locomotion_framework' (most likely due to a circular import) (/home/carlotta/iit_ws/prepare_pr/bipedal-locomotion-framework/build/bipedal_locomotion_framework/__init__.py) Introduced with commit
Sincerely I am having a hard time understanding which is the issue, in the implementation prior to the rebase, everything was working fine |
In which folder are you loading the bindings? If you do it in the build folder is not working |
Thanks @GiulioRomualdi !
I have also added the tests and all seems to pass. (Side Note: Loading the bindings not in the build directory solved the issue) |
.../ReducedModelControllers/include/BipedalLocomotion/bindings/ReducedModelControllers/Module.h
Outdated
Show resolved
Hide resolved
bindings/python/ContinuousDynamicalSystem/tests/test_centroidal_dynamics.py
Outdated
Show resolved
Hide resolved
Thank you @CarlottaSartore for the effort I will merge it as soon as the CI ends. Thank you for the effort this will be really useful for @LoreMoretti and @paolo-viceconte |
Still working on the implementation of the tests