General improvements for FloatingBaseEstimators library #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashanthr05
force-pushed
the
improve/fbe
branch
from
a31010b
to
bc09073
Compare
prashanthr05
force-pushed
the
improve/fbe
branch
from
bc09073
to
743d111
Compare
S-Dafarra
reviewed
Apr 6, 2021
src/Estimators/include/BipedalLocomotion/FloatingBaseEstimators/FloatingBaseEstimator.h
Outdated
Show resolved
Hide resolved
src/Estimators/include/BipedalLocomotion/FloatingBaseEstimators/FloatingBaseEstimatorIO.h
Show resolved
Hide resolved
src/Estimators/include/BipedalLocomotion/FloatingBaseEstimators/FloatingBaseEstimatorIO.h
Outdated
Show resolved
Hide resolved
GiulioRomualdi
approved these changes
Apr 6, 2021
prashanthr05
force-pushed
the
improve/fbe
branch
4 times, most recently
from
be91363
to
052f35a
Compare
prashanthr05
force-pushed
the
improve/fbe
branch
from
052f35a
to
0768a1c
Compare
|
I've addressed the review, rebased over latest master and changed std prints to spdlog prints in the base class implementation. |
|
@GiulioRomualdi if you think it's ok, we can merge this! |
GiulioRomualdi
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for landmarks in estimators
In-code disabling of some functionality related to InvariantEKF using a simple flag
Add logic to use estimator without specifying a model (useful for estimation that does not involve kinematics)
Update changelog