-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the possibility to change the weight in TSID/IK #475
Conversation
085f28c
to
0ada208
Compare
0ada208
to
7147ac0
Compare
@GiulioRomualdi did you wanted to ask for a review instead of assigning? |
Ops 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me. What I find misleading is that weight
is singular, but it is expecting a vector instead of a number. In general, I did not understand what is the effect of this weight? In a quadratic cost function we could have two weights
$$
w1 c(x)^T diag(w2) c(x) + w1' c(x)'^T diag(w2') c(x)'.
$$
Which weight are we changing?
Hi @S-Dafarra The weight I'm referring to is the one associated with the norm. In TSID (same for the IK) each component of the cost function is a where |
Ok I see. Basically, it is the w2 in #475 (review). Can we also set the w1? If not, then there is no ambiguity |
|
This closes #474