Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save the robot name and the names of the channel's elements #522

Merged
merged 10 commits into from
May 5, 2022

Conversation

GiulioRomualdi
Copy link
Member

@GiulioRomualdi GiulioRomualdi commented Mar 25, 2022

This PR introduces the possibility to save the robot name and the names associated with each element of a channel in the YarpRobotLoggerDevice.

@GiulioRomualdi
Copy link
Member Author

GiulioRomualdi commented Apr 8, 2022

Despite the effort for fixing windows we still have a problem (not related to this PR)

D:\a\bipedal-locomotion-framework\bipedal-locomotion-framework\src\Planners\src\SwingFootPlanner.cpp(170): error C2280: 'Eigen::Map<manif::SO3Tangent<double>,0,Eigen::Stride<0,0>>::Map(const Eigen::Map<manif::SO3Tangent<double>,0,Eigen::Stride<0,0>> &)': attempting to reference a deleted function
C:\Miniconda\envs\test\Library\include\manif/impl/so3/SO3Tangent_map.h(61): note: compiler has generated 'Eigen::Map<manif::SO3Tangent<double>,0,Eigen::Stride<0,0>>::Map' here
C:\Miniconda\envs\test\Library\include\manif/impl/so3/SO3Tangent_map.h(61): note: 'Eigen::Map<manif::SO3Tangent<double>,0,Eigen::Stride<0,0>>::Map(const Eigen::Map<manif::SO3Tangent<double>,0,Eigen::Stride<0,0>> &)': function was implicitly deleted because 'Eigen::Map<manif::SO3Tangent<double>,0,Eigen::Stride<0,0>>' has a user-defined move assignment operator

@traversaro
Copy link
Collaborator

Can't we use VS2019 for now?

@GiulioRomualdi
Copy link
Member Author

Can't we use VS2019 for now?

Do you know how to ask for vs2019?

@traversaro
Copy link
Collaborator

traversaro commented Apr 8, 2022

Can't we use VS2019 for now?

Do you know how to ask for vs2019?

Just use the windows-2019 GitHub Actions image instead of windows-latest.

@GiulioRomualdi
Copy link
Member Author

GiulioRomualdi commented Apr 8, 2022

https://github.com/ami-iit/bipedal-locomotion-framework/runs/5886634405?check_suite_focus=true#step:12:586

>       assert kindyn_desc.is_valid()
E       assert False
E        +  where False = <bound method PyCapsule.is_valid of <bipedal_locomotion_framework.bindings.floating_base_estimators.KinDynComputationsDescriptor object at 0x000002073190FF70>>()
E        +    where <bound method PyCapsule.is_valid of <bipedal_locomotion_framework.bindings.floating_base_estimators.KinDynComputationsDescriptor object at 0x000002073190FF70>> = <bipedal_locomotion_framework.bindings.floating_base_estimators.KinDynComputationsDescriptor object at 0x000002073190FF70>.is_valid

..\bindings\python\IK\tests\test_QP_inverse_kinematics.py:287: AssertionError
---------------------------- Captured stdout call -----------------------------
[2022-04-08 14:43:56.680] [thread: 6936] [blf] [info] [QPInverseKinematics::initialize] 'verbosity' not found. The following parameter will be used 'false'.
---------------------------- Captured stderr call -----------------------------
I/O error : Permission denied
I/O error : Permission denied
I/O warning : failed to load external entity "C:\Users\RUNNER~1\AppData\Local\Temp\tmpmib3us9s"
Error:  ModelLoader :: loadModelFromFile : Error in parsing model from URDF.

At this point, I would start using icub-models to get the urdf model for the tests.
Unfortunately, the current version shipped in conda-forge has a bug that has been fixed in robotology/icub-models#149 and robotology/icub-models#150.

@traversaro is it possible to release a new version of icub-models (i.e v1.23.3)?

@traversaro
Copy link
Collaborator

@traversaro is it possible to release a new version of icub-models (i.e v1.23.3)?

Done: https://github.com/robotology/icub-models/releases/tag/v1.23.3 .

@traversaro
Copy link
Collaborator

@traversaro is it possible to release a new version of icub-models (i.e v1.23.3)?

Done: https://github.com/robotology/icub-models/releases/tag/v1.23.3 .

conda-forge PR: conda-forge/icub-models-feedstock#14 . Once it is merged, we will need to wait the usual 1-2 hours for the CDN to propagate.

@GiulioRomualdi
Copy link
Member Author

Since the CI failure is not related to this PR I'm going to merge it

@GiulioRomualdi GiulioRomualdi merged commit fa7f881 into master May 5, 2022
@GiulioRomualdi GiulioRomualdi deleted the elements_robot_names branch May 5, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants