Fix the python package when installed from cmake #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the package is installed from cmake
Nicogene
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately #149 was not enough. Thanks to @Nicogene I noticed that path returned by
get_models_path()was still not existing 😭First of all, there was a bug in the construction of the
PYTHON_ABSOLUTE_INSTDIRin theCMakeLists.txtfile (fixed in 664e5af)Then I noticed that
pathlib.Path(__file__)points to the file location and not to the folder containing the file. This fixes the problem 9366eb8@Nicogene could you please check if this solves your issue?