Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get_models_path() when the icub_models package is installed with the superbuild #149

Merged
merged 2 commits into from
Apr 6, 2022
Merged

Fix get_models_path() when the icub_models package is installed with the superbuild #149

merged 2 commits into from
Apr 6, 2022

Conversation

GiulioRomualdi
Copy link
Member

@GiulioRomualdi GiulioRomualdi commented Apr 6, 2022 •
edited
Loading

cc @Nicogene

This fixes #148

@GiulioRomualdi GiulioRomualdi self-assigned this Apr 6, 2022
@GiulioRomualdi GiulioRomualdi mentioned this pull request Apr 6, 2022
Closed
@traversaro
Copy link
Member

traversaro commented Apr 6, 2022 •
edited
Loading

Thanks @GiulioRomualdi, I added a ChangeLog line.

@traversaro traversaro merged commit 73661ed into master Apr 6, 2022
@traversaro traversaro deleted the fix_python_package branch April 6, 2022 15:51
This was referenced Apr 7, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro Awaiting requested review from traversaro

Assignees

@GiulioRomualdi GiulioRomualdi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

icub_models.get_models_path() python command points to a non existing folder
2 participants
@GiulioRomualdi @traversaro