AddBipedalLocomotionYARPDevice: Enable YARP devices by deafult #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
requested review from
GiulioRomualdi and
S-Dafarra
as code owners
5 tasks
|
Thank you @traversaro |
|
Ci is failing because of catch2 on Windows. This has been handled by #575 |
|
Note that not all the devices are probably not tested in the CI (some dependecy missing?), as on conda-forge we actually have some CI failures on macOS and Windows, see conda-forge/bipedal-locomotion-framework-feedstock#6 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is quite counterintuitive that beside enabling the YARP-specific option, some more options need to be enabled to actually compile YARP devices.
See also conda-forge/bipedal-locomotion-framework-feedstock#5 .