Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RT Capabilities Part 1 - YARP Logger Device #817
RT Capabilities Part 1 - YARP Logger Device #817
Changes from 76 commits
c8134c6
76c01a2
4267db2
45bade1
c213ed7
c4da8b5
4667433
98b0563
d498c21
cf20448
296cd2c
a735dd4
f43d2d7
325d378
04c14cd
5bd0122
ca1fffb
6ca1fe9
6284950
5f4c3fb
edf8b45
c25f25d
5409fab
b83a7f6
5eabf65
554fa1e
f45bfb5
ebf9d76
9def9a5
d92f7f4
8ad4b69
c3c79ad
0ce1575
cb4838e
875e190
4815a61
1cde2ae
2781076
3ee4481
12f1649
3fda2d5
4a6f01b
20d7b65
834d618
bf7fe13
5f62eea
8d3d488
21bdbdb
3667b19
e136188
2b6ef20
2ccff2d
5ef8bb4
d24e886
482e195
3be2c8a
841138c
e5d0cdb
568addd
c16b958
52499b5
7244bca
51f9a8a
cc97f40
609e3c2
3cfaf3d
6c1fdd1
0e166b4
107860c
26f7a3a
0392a04
cf0370b
70e0b6f
3efcfe5
3f9d725
e392e93
ee4cf0d
8f0e4a8
4ea7f85
f8d16c4
9429b0e
69fa835
1939bee
0c6be42
7c8d912
1c924a9
9555d00
a91ee01
0888c96
01aea4e
0c28b90
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a leftover
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mutex is not leftover, it is used to guard the text logging port for when it is reading and when it is looking for new logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 0888c96. The change of just adding Eigen::Ref<> causes issues when saving the data via buffer manager. This is because the push_back method of the buffer manager uses a template for the data and is storing the raw data of the Eigen::Ref and not the Eigen::VectorXd. The solution was discussed and implemented with the help of @S-Dafarra in which we used a lambda function to still pass the Eigen::Vector by a reference.