Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI/CD pipeline to speed up checks on PRs not altering the Python package #128

Merged
merged 5 commits into from
Apr 3, 2024

Conversation

diegoferigo
Copy link
Member

@diegoferigo diegoferigo commented Apr 3, 2024

Partially reverts the changes of #93, as commented in #93 (comment).


📚 Documentation preview 📚: https://jaxsim--128.org.readthedocs.build//128/

@diegoferigo diegoferigo requested a review from traversaro April 3, 2024 08:25
@diegoferigo diegoferigo self-assigned this Apr 3, 2024
@diegoferigo diegoferigo requested a review from flferretti as a code owner April 3, 2024 08:25
@traversaro
Copy link
Contributor

Which this changes, are the schedule and workflow_dispatch jobs actually testing something? I am worried that we are going to ignore environment regressions (due to packages being updated) until users actually try to do pip install jaxsim.

@diegoferigo
Copy link
Member Author

Which this changes, are the schedule and workflow_dispatch jobs actually testing something? I am worried that we are going to ignore environment regressions (due to packages being updated) until users actually try to do pip install jaxsim.

I think that this PR does not alter those events. The condition is always true for events different from pull_request, regardless to the filtering:

- name: Run the Python tests
if: |
contains(matrix.os, 'ubuntu') &&
(github.event_name != 'pull_request' ||
steps.changes.outputs.all == 'true')

@traversaro
Copy link
Contributor

Ah, It was not clear to me that the only effect of the new step was just setting steps.changes.outputs.all, ok for me then.

@diegoferigo diegoferigo merged commit fbcc284 into main Apr 3, 2024
23 checks passed
@diegoferigo diegoferigo deleted the ci_cd branch April 3, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants