-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow_dispatch and schedule events to ci_cd workflow and constraint jax<0.4.25 to be #93
Conversation
I also added a step to print |
It looks good to me, thanks! Yet, I believe that activating a dependabot might be useful for this aim. What do you think about that? |
I guess dependabot needs to work on some kind of lockfile or similar used for testing. Probably we need to add something similar before adding dependabot? One thing that I would pay attention to is to avoid conflating "presumed compatibiltiy ranges of dependencies" and "version of the dependencies used for tests". |
Yes, it makes sense. Let me cc @diegoferigo |
…tests (ami-iit#80)" This reverts commit 217f743.
069c637
to
c3d9e40
Compare
Cool, anyhow it seems that tests seem to work fine with jax==0.4.24, I guess this is a good enough solution to fix the CI, we can enable back compatibility with jax==0.4.25 once we migrate tests to the functional interface. |
The conditional logic to run pytest was to reduce CI time on PRs that were not touching any Any other reason to remove previous logic? I still don't get the motivation. For the other changes, I agree on both the dispatch and the pinning. |
Ahn ok I see, you were maybe referring to changes of |
Yes, and also to check if using the latest versions of the dependencies make the build fail, like in this case |
Yes but the failure is not due to the changes of this PR specifically, I'd expect to see CI green here. I expect a new PR to fix the problem if the CI of |
The problem we experienced is that the tests also depends on:
Then idea is that if you open a PR to check if the CI works, it is a bit counterintuitive if the CI is green even if the test did not run. However, then we added also the |
Changes:
pytest
in CI only in PRs that update either sources or tests #80, as we are currently installing dependencies from a rolling release distribution (PyPI) and so it is possible that there is a test failure even if nothing changed in source files. We can introduce something similar if we start using a lockfile of some kind, if we add the logic also to check changes in the lockfile.📚 Documentation preview 📚: https://jaxsim--93.org.readthedocs.build//93/