Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin jax<0.4.25 also in environment.yml #97

Closed
wants to merge 1 commit into from

Conversation

diegoferigo
Copy link
Member

@diegoferigo diegoferigo commented Mar 1, 2024

Otherwise readthedocs fails, complementing #93.


📚 Documentation preview 📚: https://jaxsim--97.org.readthedocs.build//97/

@diegoferigo diegoferigo self-assigned this Mar 1, 2024
@diegoferigo diegoferigo marked this pull request as ready for review March 1, 2024 11:29
@diegoferigo diegoferigo requested a review from flferretti March 1, 2024 11:30
@flferretti
Copy link
Collaborator

I think the actions on #88 fail because the branch is not update to #92. Is this actually needed?

@diegoferigo diegoferigo force-pushed the diegoferigo-patch-1 branch from dc87772 to 4819b72 Compare March 1, 2024 11:33
@diegoferigo
Copy link
Member Author

I haven't tried, let me check after rebasing. Since readthedocs is not executing any code, you might be right and the documentation could build successfully.

@diegoferigo diegoferigo changed the title Pin jax<0.4.15 also in environment.yml Pin jax<0.4.25 also in environment.yml Mar 1, 2024
@diegoferigo
Copy link
Member Author

The rebase eventually worked fine after #92. Closing.

@diegoferigo diegoferigo closed this Mar 1, 2024
@diegoferigo diegoferigo deleted the diegoferigo-patch-1 branch March 1, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants