Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fixed Issue #20631 Console error on checkout after changing the allowed countries from admin #17

Merged
merged 214 commits into from
Feb 2, 2019

Conversation

amol2jcommerce
Copy link
Owner

Original Pull Request

magento#20634

Description (*)

Fixed Issue magento#20631 Console error on checkout after changing the allowed countries from admin

Fixed Issues (if relevant)

  1. Console error on checkout after changing the allowed countries from admin. magento/magento2#20631: Console error on checkout after changing the allowed countries from admin

Manual testing scenarios (*)

1. Add a product to cart as guest.
  1. Fill the shipping address and reload the page now shipping address must be filled already.
  2. Go to Admin->Stores->configuration->General, Change allowed countries single one that is not filled on checkout. like i have filled United State at checkout and change allowed countries to Libya.
    4.Now reload the checkout shipping page again.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

vpodorozh and others added 30 commits October 25, 2018 15:52
catalog:images:resize fails to process all images -> Possible underlying Magento/Framework/DB/Query/Generator issue
- fix getCountAllProductImages select and cover class with unit tests.

(cherry picked from commit 6a6079d)
catalog:images:resize fails to process all images -> Possible underlying Magento/Framework/DB/Query/Generator issue
- fix code style;

(cherry picked from commit 466daaa)
catalog:images:resize fails to process all images -> Possible underlying Magento/Framework/DB/Query/Generator issue
- fix unit test - now it can test also not only full batches, but partial as well (139 images with batch size 100);

(cherry picked from commit f6b0a2a)
catalog:images:resize fails to process all images -> Possible underlying Magento/Framework/DB/Query/Generator issue
- fix unit test - now it can test also not only full batches, but partial as well (139 images with batch size 100);

(cherry picked from commit 546e7ce)
catalog:images:resize fails to process all images -> Possible underlying Magento/Framework/DB/Query/Generator issue
- remove method return type 'void' which can be used in php7.1 or higher.
catalog:images:resize fails to process all images -> Possible underlying Magento/Framework/DB/Query/Generator issue

Ranged selects always miss the last range

Fix unit test. 11 batches expected to handle 105 items:

1: 1-10
2: 11-20
3: 21-30
4: 31-40
5: 41-50
6: 51-60
7: 61-70
8: 71-80
9: 81-90
10: 91-100
11: 101-105

(cherry picked from commit 6c24c0e)
catalog:images:resize fails to process all images -> Possible underlying Magento/Framework/DB/Query/Generator issue
- fix code style;
catalog:images:resize fails to process all images -> Possible underlying Magento/Framework/DB/Query/Generator issue
- fix code style;

(cherry picked from commit c95ce3c)
# Conflicts:
#	app/code/Magento/Catalog/i18n/en_US.csv
#	app/code/Magento/Checkout/i18n/en_US.csv
…ld be delivered to the customer when address contains '+' symbol
…ld be delivered to the customer when address contains '+' symbol
…ld be delivered to the customer when address contains '+' symbol
…ld be delivered to the customer when address contains '+' symbol
…mer default shipping address for virtual quote
…mer default shipping address for virtual quote
…mer default shipping address for virtual quote
StasKozar and others added 27 commits January 30, 2019 15:37
- MFTF version bump + allure-codeception dependency update.
- changing argument from its own attribute to part of the command
…-dev

 [Pangolin] MFTF 2.3.13 Version Bump (2.2-develop)
Accepted Public Pull Requests:
 - magento#20544: [Backport] 'wishlist-page-edit-remove-item-misalign' :: On wish list page edit, � (by @irajneeshgupta)
 - magento#20685: [Backport] update-button-issue-while-updating-billing-and-shipping-address (by @cmtickle)
 - magento#20542: [Backport] Order API resources updated. magento#20169 (by @irajneeshgupta)
 - magento#20546: [Backport] Order-view-invoices :: Order view invoices template not display prope� (by @irajneeshgupta)


Fixed GitHub Issues:
 - magento#20399: On wish list page edit, remove item misalign in 640 X 767 resolution (reported by @nainesh2jcommerce) has been fixed in magento#20544 by @irajneeshgupta in 2.2-develop branch
   Related commits:
     1. dd67730

 - magento#20169: Admin user with restricted "order create" access can "view", "cancel", etc via API (reported by @milindsingh) has been fixed in magento#20542 by @irajneeshgupta in 2.2-develop branch
   Related commits:
     1. d47fe01

 - magento#20373: Order view invoices template not display proper on ipad  (reported by @ranee2jcommerce) has been fixed in magento#20546 by @irajneeshgupta in 2.2-develop branch
   Related commits:
     1. b850eb0
Accepted Public Pull Requests:
 - magento#20739: [Backport] issue fixed magento#20563 Go to shipping information, Update qty & Addresses� (by @amol2jcommerce)
 - magento#20744: [Backport] recent-order-product-title-misaligned (by @amol2jcommerce)
 - magento#20270: [Backport] Fixed-Widget-option-labels-are-misalinged (by @amol2jcommerce)
 - magento#20613: [Backport] admin-order-info-issue2.2 (by @dipti2jcommerce)
 - magento#20418: [Backport] issue fixed magento#20304 No space between step title and saved address in c� (by @shikhamis11)
 - magento#20285: [Backport]magento#20222 Canary islands in ups carrier 2.2 (by @duckchip)
 - magento#18809: [Backport] catalog:images:resize total images count calculates incorrectly magento#18387 (by @vpodorozh)
 - magento#19461: [Backport 2.2] issue magento#18931 fixed. (by @JeroenVanLeusden)
 - magento#19655: Fixed - Shipping issue on PayPal Express magento#14712 (by @ssp58bleuciel)


Fixed GitHub Issues:
 - magento#20563: Go to shipping information, Update qty & Addresses and Enter a new address button Not aligned from left and right in 767px screen size (reported by @swetacedcoss) has been fixed in magento#20739 by @amol2jcommerce in 2.2-develop branch
   Related commits:
     1. 6e7281d

 - magento#20500: Recent Order Product Title Misaligned in Sidebar (reported by @parag2jcommerce) has been fixed in magento#20744 by @amol2jcommerce in 2.2-develop branch
   Related commits:
     1. a971270
     2. 81d8781
     3. 73cb5c8

 - magento#20113: Widget option labels are misalinged (reported by @yashwant2jcommerce) has been fixed in magento#20270 by @amol2jcommerce in 2.2-develop branch
   Related commits:
     1. 936d71f
     2. 935d3d2

 - magento#20609: Currency rate value not align proper in order information tab  when we create creditmemo from admin (reported by @dipti2jcommerce) has been fixed in magento#20613 by @dipti2jcommerce in 2.2-develop branch
   Related commits:
     1. 7bf7ce1

 - magento#20304: No space between step title and saved address in checkout  (reported by @swetacedcoss) has been fixed in magento#20418 by @shikhamis11 in 2.2-develop branch
   Related commits:
     1. 16d7461

 - magento#18387: catalog:images:resize fails to process all images -> Possible underlying Magento/Framework/DB/Query/Generator issue (reported by @gwharton) has been fixed in magento#18809 by @vpodorozh in 2.2-develop branch
   Related commits:
     1. f114f2a
     2. 95eeb9f
     3. 84590de
     4. 4653d3e
     5. d2e5345
     6. 2539a71
     7. 76bd089
     8. b81b550
     9. 051d82d
     10. 10a1a88

 - magento#18931: Product added to shopping cart / comparison list message not translated by default (reported by @arnoudhgz) has been fixed in magento#19461 by @JeroenVanLeusden in 2.2-develop branch
   Related commits:
     1. 3b521b0

 - magento#14712: Shipping issue on PayPal Express (reported by @raymond62) has been fixed in magento#19655 by @ssp58bleuciel in 2.2-develop branch
   Related commits:
     1. 8a059e6
     2. 8bdcca9
     3. c3d5010
@amol2jcommerce amol2jcommerce force-pushed the 2.2-develop-PR-port-20634 branch from 4990ed3 to 8d67213 Compare February 2, 2019 11:48
@amol2jcommerce amol2jcommerce merged commit e29d7d4 into 2.2-develop Feb 2, 2019
amol2jcommerce pushed a commit that referenced this pull request Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.