Release V5.0.0 #244

aalavandhan · 2025-03-09T13:28:12Z

No description provided.

Bumps [coverallsapp/github-action](https://github.com/coverallsapp/github-action) from 2.3.0 to 2.3.3. - [Release notes](https://github.com/coverallsapp/github-action/releases) - [Commits](coverallsapp/github-action@v2.3.0...v2.3.3) --- updated-dependencies: - dependency-name: coverallsapp/github-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [coverallsapp/github-action](https://github.com/coverallsapp/github-action) from 2.3.3 to 2.3.4. - [Release notes](https://github.com/coverallsapp/github-action/releases) - [Commits](coverallsapp/github-action@v2.3.3...v2.3.4) --- updated-dependencies: - dependency-name: coverallsapp/github-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* removed pricing strategies in favor of meta oracle * Bill broker refactor, using new meta oracle * Charm vault refactor, using new meta oracle * Updated Interfaces and Errors * updated unit tests * code review changes

Apply suggestions from code review Co-authored-by: Brandon Iles <brandon@fragments.org> review fix caching bool instead of prev deviation

* deployed new oracle and managers * updated readme

* staking subgraph, refreshing store on rebase * charm wampl vault subgraph

* adds timestamp to swap events subgraph Signed-off-by: nms-7 <nixon.ubud@gmail.com> * linting Signed-off-by: nms-7 <nixon.ubud@gmail.com> * fixed null swap creation with 0 timestamp Signed-off-by: nms-7 <nixon.ubud@gmail.com> --------- Signed-off-by: nms-7 <nixon.ubud@gmail.com>

Bumps [coverallsapp/github-action](https://github.com/coverallsapp/github-action) from 2.3.4 to 2.3.6. - [Release notes](https://github.com/coverallsapp/github-action/releases) - [Commits](coverallsapp/github-action@v2.3.4...v2.3.6) --- updated-dependencies: - dependency-name: coverallsapp/github-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* using fee factor instead of percentages to support -ve fees * unit tests * code review * convergent fee curve

* fee curve update * code review fixes

* rollover fee handles undersubscribed vault * bumped up hardhat * code review comments

…fees

openzeppelin-code · 2025-03-09T13:32:36Z

Release V5.0.0

Generated at commit: 0ba831ea47a2855f7f7346b82afdf3d6b8fd16d1

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	1 0 0 3 24 28
Dependencies	Critical High Medium Low Note Total	0 0 0 0 0 0

For more details view the full report in OpenZeppelin Code Inspector

…'s reserve

Co-authored-by: Brandon Iles <brandon@fragments.org>

Rebalancing updates

Pair operations

Removed rollover fees in favor of daily rebalance

Restructuring perp/vault fees

Cleanup - Migrated to ethers v6

DR based flash swap fees

aalavandhan · 2025-04-24T18:49:11Z

spot-vaults/contracts/BillBroker.sol

            return 0;
        }

+        // We compute equal value of perp tokens going out.


Suggested change

// We compute equal value of perp tokens going out.

brandoniles · 2025-04-24T18:53:09Z

spot-vaults/contracts/BillBroker.sol

+        // The mint fees are waived, because single sided deposits
+        // push the pool back into balance.
+        uint256 percOfAmtInSwapped = ONE.mulDiv(
+            usdAmtIn - (s.usdBalance + usdAmtIn).mulDiv(mintAmt, totalSupply_),


Suggested change

usdAmtIn - (s.usdBalance + usdAmtIn).mulDiv(mintAmt, totalSupply_),

usdAmtIn - (s.usdBalance + usdAmtIn).mulDiv(mintAmt, totalSupply_ + mintAmt),

brandoniles · 2025-04-24T19:08:58Z

spot-vaults/contracts/BillBroker.sol

-                )
-                : 0;
+        // Compute mint amount.
+        mintAmt = (totalReserveVal > 0)


Can remove the 0 check, given we already do it right above.

brandoniles · 2025-04-24T19:10:00Z

spot-vaults/contracts/BillBroker.sol

+        // The mint fees are waived, because single sided deposits
+        // push the pool back into balance.
+        uint256 percOfAmtInSwapped = ONE.mulDiv(
+            perpAmtIn - (s.perpBalance + perpAmtIn).mulDiv(mintAmt, totalSupply_),


Suggested change

perpAmtIn - (s.perpBalance + perpAmtIn).mulDiv(mintAmt, totalSupply_),

perpAmtIn - (s.perpBalance + perpAmtIn).mulDiv(mintAmt, totalSupply_ + mintAmt),

* fee policy restructure * updated perp fee and rebalance handling, audit cleanup * updated vault fee and rebalance handling, audit cleanup * interface and lib updates * updated unit tests * code review fixes #1 * code review fixes #2 * code review fix #3 * Removed subscription ratio for a global vault:perp tvl (or system ratio) (#254) * Using a system ratio target * using system state to calculate fees * using system state for fees and removed subscription liquidity check * interface updates * unit test updates * rename

dependabot bot and others added 24 commits October 17, 2024 08:31

updated cdr pricer (#229)

f8f75a0

Deployed v4.1.0 implementations

ff01352

updated spot subgraph to keep track of vault swap volume

d6e9cf5

Vault Refactor & Meta Oracle (#224)

62c5fb4

* removed pricing strategies in favor of meta oracle * Bill broker refactor, using new meta oracle * Charm vault refactor, using new meta oracle * Updated Interfaces and Errors * updated unit tests * code review changes

Scalable usdc spot strategy (#231)

70a2bc2

Apply suggestions from code review Co-authored-by: Brandon Iles <brandon@fragments.org> review fix caching bool instead of prev deviation

billy subgraph (#234)

b7694bc

Deployed new oracle contract and managers (#233)

64b9a36

* deployed new oracle and managers * updated readme

Staking subgraph (#235)

9b16d26

* staking subgraph, refreshing store on rebase * charm wampl vault subgraph

Bill broker fee curve change (#237)

6c6311e

* using fee factor instead of percentages to support -ve fees * unit tests * code review * convergent fee curve

updated charm fee yield logic (#239)

ff96931

Fee curve update (#232)

55cbb39

* fee curve update * code review fixes

Rollover fee curve update (#240)

6a9484e

* rollover fee handles undersubscribed vault * bumped up hardhat * code review comments

DR based flash swap fees

b966a8e

comment updates

9ddef4d

updated unit tests to use ethers v6, using custom mocking library

54877f0

updated tasks and deps

a7a5f41

updated perp mint fees to be paid to the vault

e8a35ed

removed perp share of fees from flash swaps, all fees go to the vault

eff36d7

added configurable dr soft bounds (curve cutoff point) to flash swap …

433263f

…fees

updated unit tests

28db923

aalavandhan force-pushed the main branch from ff01352 to 8c4f781 Compare March 9, 2025 13:30

aalavandhan added 4 commits March 9, 2025 10:12

removed rollover fees from perp

293c25d

Daily Rebalance

3d11ca3

updated unit tests

061aaf9

constant rate enrichment/debasement

e11e203

aalavandhan and others added 17 commits March 27, 2025 18:42

code review fixes v3

654d290

code review v4

68ad680

during rebalance, vault pays perps by transferring tranches into perp…

8e9f016

…'s reserve

rebalance eql

e461e1e

configurable rebalance freq

76f3831

code review v5

f9fdff0

Apply suggestions from code review

3ef2756

Co-authored-by: Brandon Iles <brandon@fragments.org>

code review fixes

b23ad28

Code review fixes

2403fb5

Co-authored-by: Brandon Iles <brandon@fragments.org>

Merge branch 'rollover-fee-removal' into rebal-param-update

2c97ec7

Merge pull request #249 from ampleforth/rebal-param-update

4a5ce29

Rebalancing updates

Merge branch 'rollover-fee-removal' into pair-ops

5bdecd3

Merge pull request #247 from ampleforth/pair-ops

6779862

Pair operations

Merge pull request #246 from ampleforth/rollover-fee-removal

abc1164

Removed rollover fees in favor of daily rebalance

Merge pull request #243 from ampleforth/fee-restructure

eed0d39

Restructuring perp/vault fees

Merge pull request #242 from ampleforth/ethers-update

e6c9aea

Cleanup - Migrated to ethers v6

Merge pull request #241 from ampleforth/fee-update

c612dea

DR based flash swap fees

aalavandhan changed the title ~~WIP: Release V5.0.0 - Under Development~~ Release V5.0.0 - Under Review Apr 18, 2025

aalavandhan added the in-review Currently in review label Apr 18, 2025

aalavandhan commented Apr 24, 2025

View reviewed changes

brandoniles reviewed Apr 24, 2025

View reviewed changes

aalavandhan added 3 commits May 6, 2025 12:34

bill broker single sided deposit fix (#253)

04df144

Merge branch 'main' into development

5a56762

aalavandhan changed the title ~~Release V5.0.0 - Under Review~~ Release V5.0.0 May 8, 2025

updated deps

0ba831e

aalavandhan merged commit 25a4544 into main May 8, 2025
1 check passed

aalavandhan deleted the development branch May 8, 2025 16:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Release V5.0.0 #244

Release V5.0.0 #244

Uh oh!

aalavandhan commented Mar 9, 2025

Uh oh!

openzeppelin-code bot commented Mar 9, 2025 •

edited

Loading

Uh oh!

aalavandhan Apr 24, 2025

Uh oh!

brandoniles Apr 24, 2025

Uh oh!

brandoniles Apr 24, 2025

Uh oh!

brandoniles Apr 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	usdAmtIn - (s.usdBalance + usdAmtIn).mulDiv(mintAmt, totalSupply_),
	usdAmtIn - (s.usdBalance + usdAmtIn).mulDiv(mintAmt, totalSupply_ + mintAmt),

	perpAmtIn - (s.perpBalance + perpAmtIn).mulDiv(mintAmt, totalSupply_),
	perpAmtIn - (s.perpBalance + perpAmtIn).mulDiv(mintAmt, totalSupply_ + mintAmt),

Release V5.0.0 #244

Release V5.0.0 #244

Uh oh!

Conversation

aalavandhan commented Mar 9, 2025

Uh oh!

openzeppelin-code bot commented Mar 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release V5.0.0

🚨 Report Summary

Uh oh!

aalavandhan Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

brandoniles Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

brandoniles Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

brandoniles Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

openzeppelin-code bot commented Mar 9, 2025 •

edited

Loading