Extend WordPress.tv embed handler to also handle VideoPress #4755
Conversation
|
I'll have to account for this in #4650. |
|
Actually, the solution that I have does unintentionally fix this bug. Would you still consider having this merged? |
|
We can defer to your solution instead. |
|
Or rather, rebase this exclusively to the 1.5 branch perhaps. |
|
Yes, that'd make sense. |
westonruter
force-pushed
the
fix/videopress
branch
from
fa21465
to
edeca24
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
googlebot
added
cla: no
westonruter
added
cla: yes
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
westonruter
force-pushed
the
fix/videopress
branch
from
edeca24
to
bb0a315
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
@pierlon This PR has exposed that builds in the 1.5 branch are failing and have been failing:
Could you investigate and fix? |
|
Sure I'll see what the problem is. |
* Fix unit tests * Add loading attribute depending on WP version (cherry picked from commit 4f9ac9c)
* Update spec files * Adapt spec test to extract configuration arguments from input files * Add STYLES configuration key to AmpRuntimeCss transformer * Nake use of styles provided via config if available * Remove runtime style tag if stylesheet is linked * Add more tests to assert runtime transformer behavior * Complete stubbed requests data * Remove unused import * Add git attributes file to mark certain file as being generated * Use substr() instead of a replacement for removing the leading comment * Remove redundant JSONOBJECT_AS_ARRAY constant * Move .gitattributes file into lib/optimizer folder * Revert "Move .gitattributes file into lib/optimizer folder"
* Make configuration argument optional for transformation engine * Replace reference to Go filename * Replace copypasta in filesystem transport * Swap required order of configuration and remote erequest objects * Add `null` type information where applicable * Fix broken tests * Use reflection to detect dependencies in correct order * Add tests for dependency resolution * Remove Configurable interface from schema transformer * Fix broken test about link ordering after optimization
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
googlebot
added
cla: no
|
@googlebot I consent. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
googlebot
added
cla: yes
|
@westonruter All seems well now. I've backported some fixes from the |
|
Thank you very much for wrestling with this one. |
Summary
Fixes #4754.
WordPress.tv uses the VideoPress infrastructure. However, we were only directly supporting WordPress.tv but not embeds from VideoPress itself. This fixes that. Note that both WordPress.tv and VideoPress are blocks that core supports.
Checklist