fix(@ngtools/webpack): add template/styles as dependencies #5492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansl
force-pushed
the
resources-deps
branch
3 times, most recently
from
1b4e44a to
bfcdc68
Compare
filipesilva
approved these changes
Mar 20, 2017
package.json
Outdated
| @@ -131,6 +131,7 @@ | |||
| "conventional-changelog": "^1.1.0", | |||
| "dtsgenerator": "^0.9.1", | |||
| "eslint": "^3.11.0", | |||
| "eslint-plugin-standard": "^2.1.1", | |||
There was a problem hiding this comment.
I don't think you meant to have this here.
There was a problem hiding this comment.
Not sure what's that doing there. Done
So they are rebuilt when the resource changes. This PR refactor _replaceResources into _getResourceNodes which returns the AST nodes for templateUrl or styleUrls, then use that to get the URLs (values). For values that are not computable, we simply ignores.
|
LGTM |
tr11
reviewed
Mar 24, 2017
| const arr = <ts.ArrayLiteralExpression[]>( | ||
| refactor.findAstNodes(node, ts.SyntaxKind.ArrayLiteralExpression, false)); | ||
| if (!arr || arr.length == 0 || arr[0].elements.length == 0) { | ||
| return; |
There was a problem hiding this comment.
Should we change this to return [];? If you have a styleUrls: [] in your Component definition, this will cause ng to fail compilation.
There was a problem hiding this comment.
@tr11 that sounds like something that should be fixed. Would you be willing to make a PR with your fix and a test?
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So they are rebuilt and type checked when the resource changes.