Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Animation staggering issue in 1.4.4 #12594

Closed
serjrd opened this issue Aug 16, 2015 · 9 comments
Closed

Animation staggering issue in 1.4.4 #12594

serjrd opened this issue Aug 16, 2015 · 9 comments

Comments

@serjrd
Copy link

serjrd commented Aug 16, 2015

Here's a plunker snippet that illustrates the issue: http://plnkr.co/edit/PSuu2IOG03fv2ifNTTwQ?p=preview

With the version 1.4.4 there's no staggering.
But If you change the included angular version to 1.4.3 - staggering works fine.

This is under Ubuntu / Chrome Version 44.0.2403.125 (64-bit).

@datnordstrom
Copy link

1+

I've experienced this as well. I've had to use 1.4.3 of angular-animate

@foersto
Copy link

foersto commented Aug 18, 2015

+1

@Narretz
Copy link
Contributor

Narretz commented Aug 20, 2015

@matsko can you take a look?

@matsko
Copy link
Contributor

matsko commented Aug 20, 2015

This isn't entirely broken. You can still get the stagger to work by adding transition-duration: 0s into the stagger CSS selector.

http://plnkr.co/edit/PSuu2IOG03fv2ifNTTwQ?p=preview
By the way there is no need to define the -webkit- properties for transitions anymore.

This was mentioned in the stagger docs:
https://docs.angularjs.org/api/ngAnimate#css-staggering-animations

Unfortunately with 1.4.4 and onwards this is always the case. You must always define the duration value as 0s since we changed the way the ng-EVENT classes are applied. I completely missed making note of this in the CHANGELOG as a breaking change. I will make sure it shows up in the 1.4.5 release notes.

@matsko matsko closed this as completed Aug 20, 2015
matsko added a commit to matsko/angular.js that referenced this issue Aug 20, 2015
…erty

As of 1.4.4 this property needs to always be in the CSS code

Related angular#12594
@matsko
Copy link
Contributor

matsko commented Aug 20, 2015

This PR contains a fix to the docs: #12637

matsko added a commit to matsko/angular.js that referenced this issue Aug 20, 2015
…erty

As of 1.4.4 this property needs to always be in the CSS code

Related angular#12594
matsko added a commit that referenced this issue Aug 20, 2015
…erty

As of 1.4.4 this property needs to always be in the CSS code

Related #12594
Closes #12637
@serjrd
Copy link
Author

serjrd commented Aug 21, 2015

Thanks, that helped for the transition animation.

And what about the keyframes animation? I tried it with the 'animation-duration: 0s' property, but it didn't help.
Same code works fine under the 1.4.3 version.
See the example: http://plnkr.co/edit/uAFFOhZ32mDYQVp4Fcco?p=preview

@abruzzihraig
Copy link

I met the issue like @serjrd too, the 1.4.4 version still has a bug in keyframes when use stagger.

And my code like below:
http://codepen.io/abruzzi/pen/VLodOK

when you choose 1.4.3 version, the code works fine.

Another thing I have noticed that when you write 'transition-duration: 0' without 's', the stagger not performed like we expected, but in 1.4.3, it works.

@matsko
Copy link
Contributor

matsko commented Aug 25, 2015

There is a fix in place for 1.4.5 that fixes both: http://plnkr.co/edit/SkKZaH6qQmgX5w6YoGk9?p=preview

@matsko matsko reopened this Aug 25, 2015
@abruzzihraig
Copy link

@matsko It works fine, thank you!

matsko added a commit to matsko/angular.js that referenced this issue Aug 25, 2015
This reverts the previous behaviour of using foreced reflows to deal
with preparation classes in favour of a system that uses
requestAnimationFrame (RAF).

Closes angular#12669
Closes angular#12594
Closes angular#12655
Closes angular#12631
Closes angular#12612
matsko added a commit to matsko/angular.js that referenced this issue Aug 25, 2015
This reverts the previous behaviour of using foreced reflows to deal
with preparation classes in favour of a system that uses
requestAnimationFrame (RAF).

Closes angular#12669
Closes angular#12594
Closes angular#12655
Closes angular#12631
Closes angular#12612
Closes angular#12187
matsko added a commit to matsko/angular.js that referenced this issue Aug 27, 2015
This reverts the previous behaviour of using foreced reflows to deal
with preparation classes in favour of a system that uses
requestAnimationFrame (RAF).

Closes angular#12669
Closes angular#12594
Closes angular#12655
Closes angular#12631
Closes angular#12612
Closes angular#12187
matsko added a commit to matsko/angular.js that referenced this issue Aug 27, 2015
This reverts the previous behaviour of using foreced reflows to deal
with preparation classes in favour of a system that uses
requestAnimationFrame (RAF).

Closes angular#12669
Closes angular#12594
Closes angular#12655
Closes angular#12631
Closes angular#12612
Closes angular#12187
@matsko matsko closed this as completed in ea8016c Aug 27, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants