fix(cdk-experimental/listbox): clean up some TODOs #25005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
added
the
dev-app preview
crisbeto
reviewed
Jun 2, 2022
mmalerba
commented
Jun 2, 2022
|
Deployed dev-app to: https://ng-comp-dev--pr-25005-1b4f50b140de6e5a0289e6315e2f5e9c-ftthdlb0.web.app |
crisbeto
approved these changes
Jul 13, 2022
mmalerba
added a commit
that referenced
this pull request
Jul 14, 2022
* fix(cdk-experimental/listbox): clean up some TODOs * fix(cdk-experimental/listbox): address comments * fixup! fix(cdk-experimental/listbox): address comments * fixup! fix(cdk-experimental/listbox): address comments (cherry picked from commit 27b4d6a)
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Jul 24, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | minor | [`14.0.6` -> `14.1.0`](https://renovatebot.com/diffs/npm/@angular%2fcdk/14.0.6/14.1.0) | | [@angular/material](https://github.com/angular/components) | dependencies | minor | [`14.0.6` -> `14.1.0`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/14.0.6/14.1.0) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v14.1.0`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1410-neon-plate-2022-07-20) [Compare Source](angular/components@14.0.6...14.1.0) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [176213d70](angular/components@176213d) | feat | **scrolling:** make scroller element configurable for virtual scrolling ([#​24394](angular/components#24394)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [1256c6cf2](angular/components@1256c6c) | feat | **core:** use strong focus indicators in high contrast mode | | [dd1a0feb5](angular/components@dd1a0fe) | feat | **icon:** SEO friendly ligature icons ([#​24578](angular/components#24578)) | | [799cf7cf2](angular/components@799cf7c) | fix | **datepicker:** add i18n strings ([#​25024](angular/components#25024)) | ##### cdk-experimental | Commit | Type | Description | | -- | -- | -- | | [5c2a7e00e](angular/components@5c2a7e0) | fix | **listbox:** clean up some TODOs ([#​25005](angular/components#25005)) | | [0b5963753](angular/components@0b59637) | fix | **listbox:** clean up the listbox API and make it work with forms ([#​24920](angular/components#24920)) | ##### material-experimental | Commit | Type | Description | | -- | -- | -- | | [864f92e0f](angular/components@864f92e) | feat | **mdc-button:** support custom leading/trailing icons ([#​24987](angular/components#24987)) | | [1f6810831](angular/components@1f68108) | feat | **mdc-list:** add support for activated state in harness ([#​24934](angular/components#24934)) | | [c543db57a](angular/components@c543db5) | fix | **mdc-checkbox:** remove extra a11y tree node for the <label/> ([#​24907](angular/components#24907)) | | [7736515f1](angular/components@7736515) | fix | **mdc-form-field:** ensure appearance is valid ([#​24963](angular/components#24963)) | #### Special Thanks Adrien Crivelli, Amy Sorto, Andrew Seguin, Jackie Chu, Kristiyan Kostadinov, Maxi, Miles Malerba, Paul Gschwendtner, Wagner Maciel, Zach Arend and atrawally <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMTkuMiIsInVwZGF0ZWRJblZlciI6IjMyLjExOS4yIn0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1470 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
This was referenced Aug 1, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses:
SelectionModelin favor of just using a singleSelectionModelCdkComboboxdependencyDeprecation Note:
The
select,deselect,setSelection,toggle, andclearmethods onSelectionModelfrom@angular/cdk/collectionsnow return a boolean indicating whether the selection changed as a result of the call. For backwards compatibility the methods are typed asboolean | void, but this will be changed tobooleanin version 16.