-
Notifications
You must be signed in to change notification settings - Fork 3.4k
md-chips: Focus state is triggered incorrectly #2607
Comments
Can you provide some more details? Which browser, and which demo? The |
I'm using Chrome Version 42.0.2311.135 (64-bit) It's the Custom Inputs section of the demo |
I'm still not seeing it. Some screenshots of the focused state and the Element inspector open would help narrow it down. Also, which element has |
I'm not able to take a screenshot because pressing the command key while focused in the input sets the .md-focused class correctly. I'll outline the steps to reproduce below:
I am seeing this behavior in Firefox as well. |
Ok, I see what you mean now–it's the |
@chrisguerrero A lot has changed with the chips recently, and I can't seem to reproduce this issue in 0.10.1 or master. Can you verify if this has been fixed or if it's still an issue? If it is still an issue, can you provide the instructions again? I don't see any existing chips in the Custom Inputs demo, so I think the demo itself may have changed. Thanks! |
@topherfangio I do still see the issue in 0.10.1 and master, and the "Custon Inputs" demo is still there. It's one of the top level sections with a blue header, alongside "Basic Usage", "Contact Chips" and "Static Chips". The "md-focused" class is still being applied incorrectly, and the steps to reproduce are the same as my comment from 4/29. |
@chrisguerrero My apologies for making you comment again, I think I misread your instructions; I thought you were saying to click an existing chip, not the input, which is why I was confused. I definitely see the issue now and will look into it :-) |
* Fix backspace key in Firefox to not change browser history/url In Firefox, the backspace key would also modify the browser's history/url. * Fix focus/blur on chips with custom input: Chips with a custom input did not properly update it's class list when the inner input was focused/blurred. Fixes #3562. References #3960. Fixes #2607.
* Fix backspace key in Firefox to not change browser history/url In Firefox, the backspace key would also modify the browser's history/url. * Fix focus/blur on chips with custom input: Chips with a custom input did not properly update it's class list when the inner input was focused/blurred. Fixes #3562. Fixes #3960. Fixes #2607.
* Fix backspace key in Firefox to not change browser history/url In Firefox, the backspace key would also modify the browser's history/url. * Fix focus/blur on chips with custom input: Chips with a custom input did not properly update it's class list when the inner input was focused/blurred. Fixes angular#3562. Fixes angular#3960. Fixes angular#2607. Closes angular#4359.
I just updated to v0.9.0rc3 and noticed that the
.md-focused
class is applied to the wrong element.The focus state is applied properly if I press ctrl or cmd while focussed on the element.
The text was updated successfully, but these errors were encountered: