This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(mdChips): Backspace key and custom input focus/blur. #4359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topherfangio
added
the
pr: merge ready
|
This fixes the issue in Edge as well (#3960). However, I got "$apply already in progress" errors during my testing (both Chrome and Edge), likely from the digest loop you added. |
topherfangio
added
needs: review
|
@ngraef Thanks for the confirmation, and for finding the issue! I'm looking into it now. Looks like it only happens on chips with custom inputs... |
* Fix backspace key in Firefox to not change browser history/url In Firefox, the backspace key would also modify the browser's history/url. * Fix focus/blur on chips with custom input: Chips with a custom input did not properly update it's class list when the inner input was focused/blurred. Fixes #3562. Fixes #3960. Fixes #2607.
topherfangio
force-pushed
the
fix-chips-multiple
branch
from
efc86b3
to
968acc0
Compare
topherfangio
added
pr: merge ready
|
@ngraef Thanks again for catching the issue! I have changed the code to use |
kennethcachia
pushed a commit
to kennethcachia/material
that referenced
this pull request
Sep 23, 2015
* Fix backspace key in Firefox to not change browser history/url In Firefox, the backspace key would also modify the browser's history/url. * Fix focus/blur on chips with custom input: Chips with a custom input did not properly update it's class list when the inner input was focused/blurred. Fixes angular#3562. Fixes angular#3960. Fixes angular#2607. Closes angular#4359.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix backspace key in Firefox to not change browser history/url
In Firefox, the backspace key would also modify the browser's
history/url.
Fix focus/blur on chips with custom input:
Chips with a custom input did not properly update it's class
list when the inner input was focused/blurred.
Fixes #3562. Fixes #3960. Fixes #2607.