This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
chips: backspace to select broken in Edge #3960
Labels
browser: IE
This issue is specific to Internet Explorer
Comments
ThomasBurleson
added
needs: review
This PR is waiting on review from the team
and removed
needs: review
This PR is waiting on review from the team
labels
Jul 31, 2015
typotter
added
browser: IE
This issue is specific to Internet Explorer
and removed
needs: review
This PR is waiting on review from the team
labels
Aug 10, 2015
I can confirm this happens in Firefox 39 too. If there's text which wasn't yet confirmed (not a chip yet), that text is deleted on backspace. As soon as there's no text left, another backspace hit navigates to previous url and no chip is deleted. If the previous page was another angular ui demo page, then the url changes but it actually stays on the current page, with scrollbar problem from there on: |
topherfangio
added a commit
that referenced
this issue
Aug 27, 2015
* Fix backspace key in Firefox to not change browser history/url In Firefox, the backspace key would also modify the browser's history/url. * Fix focus/blur on chips with custom input: Chips with a custom input did not properly update it's class list when the inner input was focused/blurred. Fixes #3562. References #3960. Fixes #2607.
@ngraef Any chance you could test the PR I submitted yesterday which fixes this issue in Firefox and let us know if this fixes the issue in IE Edge as well? If so, I'll update the description to ensure this issue gets closed at the same time. |
@topherfangio Yup, I'll take a look. |
topherfangio
added a commit
that referenced
this issue
Aug 28, 2015
* Fix backspace key in Firefox to not change browser history/url In Firefox, the backspace key would also modify the browser's history/url. * Fix focus/blur on chips with custom input: Chips with a custom input did not properly update it's class list when the inner input was focused/blurred. Fixes #3562. Fixes #3960. Fixes #2607.
kennethcachia
pushed a commit
to kennethcachia/material
that referenced
this issue
Sep 23, 2015
* Fix backspace key in Firefox to not change browser history/url In Firefox, the backspace key would also modify the browser's history/url. * Fix focus/blur on chips with custom input: Chips with a custom input did not properly update it's class list when the inner input was focused/blurred. Fixes angular#3562. Fixes angular#3960. Fixes angular#2607. Closes angular#4359.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In Edge browser, backspace navigates back rather than selecting the previous chip.
Not sure if you're in the business of supporting Edge yet, so maybe this can be thrown in the backlog.
The text was updated successfully, but these errors were encountered: