-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtual scrolling helpers / utilities. #823
Comments
Would be good to implement dynamic height (angular/material#4314) |
Does someone know a repo do this virtual scroll instead of ngFor ? Today we have a very large set of data, it's primordial to begin/HAVE this feature instead of something like "tooltip" or so ! @jelbourn Displaying big data is important today please begin with something hard instead of "tooltip" ps: https://developers.google.com/web/updates/2016/07/infinite-scroller |
@istiti Polymer has Please recognize that you are asking about a feature that most projects don't need/use and is a technical challenge to put into a library in a fully formed, universal way... You could probably write your own version, but it might not be what I would need... Tooltip is a super easy use case for portals and overlay's which are core to everything from menu's to dialogs so is rather simple to release and common enough that most use cases fit. The link you gave has a link to his source code and it's only 400ish lines. I bet you could make a ng2 version and contributing it back to the community for free would be awesome! |
@DennisSmolek "Infinite scrollers pop up all over the internet. Google Music’s artist list is one, Facebook’s timeline is one and Twitter’s live feed is one as well" UpdateImpossible to get iron list working (very comlpicate) if you have an github repo doing virtual Dom, you're welcome |
yes but this add more complexities to my app ... really a bad choice but I find angular2-data-table which do work very awesome thanks |
ETA? |
I've ported the old one and wonder if I there's some form of spec available so I can align my implementation with it. The mdVirtualRepeat is almost (as in line-to-line) the same, but structural repeater had to be made by scratch based on ngFor and mdVirtualRepeat. |
@Klaster1 , any chance you could fork material2 and add your work to the library? If there was at least an initial PR we could get some momentum going behind this. |
ngx-datatable has an implementation of virtual scroll. I wonder if that couldn't be easily brought in? |
@jelbourn If this sounds good to you, I can make a PR with the initial version and if the components pleases most I can work on the maxHeight issue. Let me know if you're interested. |
@ThibaultSavary we want to explore solutions for non fix-sized items in material2. |
@jelbourn is that the sort of thing that can be implemented in a version bump down the road? Variable height is a tricky issue to solve with virtual repeaters, and I'm not sure insisting upon its inclusion is a realistic goal. If we could at least get feature parity with Angular Material 1.0, it would be a massive help; Our company is pretty dependent on To be sure, flexible height would be a great feature, I'm just not sure it's as much of a requirement as having virtual repeat in the first place. |
@jelbourn I fully agree with @bryanrideshark for virtual scroll to be exact in height is not top priority. Exact position affects scrollbar position on the right, but normally it is only a visual effect. |
@bryanrideshark & @laserus I don't agree with you guys... if the team implements the v1 (from material 1), a better version will probably never be explored! The team's time is limited and they should focus on innovation rather than existing technologies |
+1 for innovation ps:wait this feature since 5 months |
+1 for the flexible height. |
@natcohen all of what will / will not happen is speculation unless we're actually decision makers in the matter, IE, core members of the team. As this is a blocking issue for other things (autocomplete, md-select), would someone on the team be able to provide some sort of feedback as to where this issue stands? |
+1 for the flexible height |
+1 need this badly! |
@byronsanchez - You can use it today in cdk-experimental |
For the sake of us joining this years-old item late, can anyone point to any currently available code (presumably a combination of CDK experimental and outside code) which simultaneously provides the following?
? |
@kylecordes - The next phase is to integrate this with the other components such as table and tree. Stay tuned for updates on that. |
@kylecordes Take a look here https://virtual-grid-mat.stackblitz.io/ |
Anyone tried it with Angular Universal? |
Can anyone please confirm if the following features are supported in current implementation:
Secondly, is it necessary to set height of the |
No idea for scrollTo/scrollToIndex. I can answer for height. I set my virtual scroll viewport using flex layout and it work with no fixed size. See this https://stackblitz.com/edit/angular-virtual-scroll-and-flex-layout-working |
Thanks for sharing this @bsthilaire it seems that this solution doesn't work with |
I modified my stackblitz for autosize and it's still working with flex-layout. https://stackblitz.com/edit/angular-virtual-scroll-and-flex-layout-randomsize |
I am doing tests on IE11 using stackblitz of @bsthilaire for now. Blank zone at the end of the scrollbar (sometimes) not present on CHrome and Edge IE11 is glitchy. Do you prefer to have a dedicated Issue to track all problem about IE11? or do we go one by one with different issues? |
@amcdnl it seems that the scrolling through arrow keys (up/down) doesn't work properly. It does scroll for few items and after that stops working. To replicate the issue, open https://stackblitz.com/edit/angular-virtual-scroll-and-flex-layout-randomsize click on any element of the list and then use arrow keys to scroll. cc @mmalerba |
@nasreddineskandrani The gap at the end is alread tracked by #11195 |
@bsthilaire thanks! i referenced this issue in the issue you mentionned. Since like that we can see the status here :). |
I've been tracking all of the virtual scroll issues in this project: https://github.com/angular/material2/projects/20 Sorry for the lack of responsiveness, I just got back from a long vacation, will resume working on this now that I'm back |
Anyone tried infinite scroll with
And
This seems to work, but has performance issues, so in order to optimize the performance I tried adding debounceTime.
But this doesn't seems to work and throw below error
I also tried moving the code to |
I think this issue is growing too much. Devs are reporting here all bugs/questions. Like closing this issue and let a message at the end to encourage devs open specific issues/questions... with in the tittle And maybe also having a specific ReadMe link under 'virtual-scroll' feature folder that document the virtual-scroll and giving a status about the feature. |
I'm planning to leave this issue open until the virtual scroll is available in cdk (rather than cdk-experimental). If people have specific bugs they've encountered they should open a new issue. Discussion and troubleshooting should happen on Gitter, Stack Overflow, etc |
I wrote a library for it in angualr 6. it uses cdk virtual component and supports end triggers. check out: https://github.com/aprola/ngx-infinite-virtual-scroll |
@gshireesh Your demo is not working |
@manju-reddys thanks for pointing it out. I busted npm cache. now it works fine. |
Do you think that this features could be used for virtualization of horizontal scrolling? |
@mmalerba Is there ongoing work being done on this AutosizeVirtualScrollStrategy? It looks like the code has been stagnant for 3 months. |
Any news on autosize? |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Similar to the
md-virtual-repeat
in Angular Material 1.The text was updated successfully, but these errors were encountered: