Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update first-run-needed string #15764

Closed
wants to merge 1 commit into from
Closed

chore: update first-run-needed string #15764

wants to merge 1 commit into from

Conversation

mikehardy
Copy link
Member

Purpose / Description

from issue - slight optimization of wording

Fixes

Approach

Take feedback, minimal change, go

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 3, 2024

Message to maintainers, this PR contains strings changes.

  1. Before merging this PR, it is best to run the "Sync Translations" GitHub action, then make and merge a PR from the i18n_sync branch to get translations cleaned out.
  2. Then merge this PR, and immediately do another translation PR so the huge change made by this PR's key changes are all by themselves.

Read more about updating strings on the wiki,

@mikehardy mikehardy requested a review from BrayanDSO March 3, 2024 22:50
@mikehardy mikehardy added this to the 2.17.3 release milestone Mar 3, 2024
@mikehardy mikehardy mentioned this pull request Mar 3, 2024
Closed
@NameLessGO
Copy link

NameLessGO commented Mar 3, 2024 •
edited
Loading

Translations come and go, if the devs prefer the phrase 3 (David suggestion), then we will translate accordingly

Try again after opening AnkiDroid

Simpler sentences are better to translate anyway

@lukstbit lukstbit added the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Mar 4, 2024
david-allison
david-allison requested changes Mar 4, 2024
View reviewed changes
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to update the key?

@lukstbit lukstbit added the Needs Author Reply Waiting for a reply from the original author label Mar 4, 2024
@mikehardy
Copy link
Member Author

I don't care enough

@mikehardy mikehardy closed this Mar 4, 2024
@mikehardy
Copy link
Member Author

In other words, no, and don't care, and no 🤷

@mikehardy mikehardy removed Needs Author Reply Waiting for a reply from the original author Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) Queued for Cherry Pick to Stable Branch labels Mar 4, 2024
@mikehardy mikehardy deleted the first-run-string-optimization branch March 4, 2024 18:16
@david-allison david-allison mentioned this pull request Mar 4, 2024
Merged
@david-allison david-allison removed this from the 2.17.3 release milestone Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-allison david-allison david-allison requested changes

@BrayanDSO BrayanDSO BrayanDSO approved these changes

@lukstbit lukstbit lukstbit approved these changes

Assignees
No one assigned
Labels
Strings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

String Suggestion for: "AnkiDroid is not initialized yet. Please open AnkiDroid once, then try again"
5 participants
@mikehardy @NameLessGO @lukstbit @david-allison @BrayanDSO