Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update first-run-needed string #15770

Merged
merged 1 commit into from
Mar 4, 2024
Merged

chore: update first-run-needed string #15770

merged 1 commit into from
Mar 4, 2024

Conversation

david-allison
Copy link
Member

@david-allison david-allison commented Mar 4, 2024 •
edited
Loading

@david-allison @mikehardy
chore: update first-run-needed string
55f8e9b 
Review follow up from PR 15764: updated key

Co-authored-by: Mike Hardy <github@mikehardy.net>
@david-allison david-allison added Needs Review cleanup Non functional change that would improve the code readability Strings labels Mar 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2024

Message to maintainers, this PR contains strings changes.

  1. Before merging this PR, it is best to run the "Sync Translations" GitHub action, then make and merge a PR from the i18n_sync branch to get translations cleaned out.
  2. Then merge this PR, and immediately do another translation PR so the huge change made by this PR's key changes are all by themselves.

Read more about updating strings on the wiki,

@david-allison david-allison added this to the 2.17.3 release milestone Mar 4, 2024
@mikehardy mikehardy enabled auto-merge March 4, 2024 18:40
@mikehardy
Copy link
Member

strings PR already in merge queue, this will entrain after

@mikehardy mikehardy added this pull request to the merge queue Mar 4, 2024
Merged via the queue into ankidroid:main with commit 5e205fb Mar 4, 2024
10 checks passed
@github-actions github-actions bot modified the milestones: 2.17.3 release, 2.18 release Mar 4, 2024
@mikehardy mikehardy modified the milestones: 2.18 release, 2.17.4 release Mar 5, 2024
@david-allison david-allison mentioned this pull request Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehardy mikehardy mikehardy approved these changes

Assignees
No one assigned
Labels
Cherry Picked to Stable Branch cleanup Non functional change that would improve the code readability Strings
Projects
None yet
Milestone
2.17.4 release
Development

Successfully merging this pull request may close these issues.

String Suggestion for: "AnkiDroid is not initialized yet. Please open AnkiDroid once, then try again"
2 participants
@david-allison @mikehardy